From 9373b5afb0a759042c3475dfcea90bf9bf2da2d6 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Fri, 8 Dec 2023 09:00:03 -0800 Subject: [PATCH] build: defer Node 20 compatibility --- .github/workflows/after-merge.yml | 3 +- .github/workflows/test-all-packages.yml | 43 ++++++++++++++------- golang/cosmos/package.json | 2 +- package.json | 2 +- packages/ERTP/package.json | 2 +- packages/SwingSet/package.json | 2 +- packages/assert/package.json | 2 +- packages/base-zone/package.json | 2 +- packages/boot/package.json | 2 +- packages/builders/package.json | 2 +- packages/cache/package.json | 2 +- packages/casting/package.json | 2 +- packages/cosmic-swingset/package.json | 2 +- packages/deploy-script-support/package.json | 2 +- packages/governance/package.json | 2 +- packages/import-manager/package.json | 2 +- packages/inter-protocol/package.json | 2 +- packages/internal/package.json | 2 +- packages/network/package.json | 2 +- packages/notifier/package.json | 2 +- packages/pegasus/package.json | 2 +- packages/same-structure/package.json | 2 +- packages/solo/package.json | 2 +- packages/sparse-ints/package.json | 2 +- packages/spawner/package.json | 2 +- packages/store/package.json | 2 +- packages/swingset-liveslots/package.json | 2 +- packages/telemetry/package.json | 2 +- packages/time/package.json | 2 +- packages/vat-data/package.json | 2 +- packages/vats/package.json | 2 +- packages/vm-config/package.json | 2 +- packages/zoe/package.json | 2 +- packages/zone/package.json | 2 +- 34 files changed, 62 insertions(+), 48 deletions(-) diff --git a/.github/workflows/after-merge.yml b/.github/workflows/after-merge.yml index 226443270e8..30de8d6b5d3 100644 --- a/.github/workflows/after-merge.yml +++ b/.github/workflows/after-merge.yml @@ -15,7 +15,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: ['18.x', '20.x'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + node-version: ['18.x'] steps: - uses: actions/checkout@v3 with: diff --git a/.github/workflows/test-all-packages.yml b/.github/workflows/test-all-packages.yml index 1f661aedac9..805b862fbf2 100644 --- a/.github/workflows/test-all-packages.yml +++ b/.github/workflows/test-all-packages.yml @@ -31,7 +31,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: ['18.x', '20.x'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + node-version: ['18.x'] steps: - uses: actions/checkout@v3 with: @@ -64,7 +65,7 @@ jobs: - uses: actions/checkout@v3 - uses: ./.github/actions/restore-node with: - node-version: '20.x' + node-version: '18.x' # first job also does repo-level linting - name: lint repo format @@ -84,7 +85,7 @@ jobs: - uses: actions/checkout@v3 - uses: ./.github/actions/restore-node with: - node-version: '20.x' + node-version: '18.x' - name: yarn lint rest run: ./scripts/lint-with-types.sh rest @@ -98,7 +99,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - engine: ['18.x', '20.x', 'xs'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x', 'xs'] steps: - name: set vars id: vars @@ -189,7 +191,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - engine: ['18.x', '20.x', 'xs'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x', 'xs'] steps: - name: set vars id: vars @@ -306,7 +309,8 @@ jobs: strategy: matrix: # test:xs is noop in solo/package.json - engine: ['18.x', '20.x'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x'] steps: - name: set vars id: vars @@ -347,7 +351,8 @@ jobs: strategy: matrix: # test:xs is noop in cosmic-swingset/package.json - engine: ['18.x', '20.x', 'xs'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x', 'xs'] steps: - name: set vars id: vars @@ -391,7 +396,8 @@ jobs: strategy: matrix: # test:xs is noop in inter-protocol/package.json - engine: ['18.x', '20.x'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x'] steps: - name: set vars id: vars @@ -431,7 +437,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - engine: ['18.x', '20.x', 'xs'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x', 'xs'] steps: - name: set vars id: vars @@ -472,7 +479,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - engine: ['18.x', '20.x', 'xs'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x', 'xs'] steps: - name: set vars id: vars @@ -514,7 +522,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - engine: ['18.x', '20.x', 'xs'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x', 'xs'] steps: - name: set vars id: vars @@ -566,7 +575,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - engine: ['18.x', '20.x', 'xs'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x', 'xs'] steps: - name: set vars id: vars @@ -607,7 +617,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - engine: ['18.x', '20.x', 'xs'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x', 'xs'] steps: - name: set vars id: vars @@ -649,7 +660,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - engine: ['18.x', '20.x', 'xs'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x', 'xs'] steps: - name: set vars id: vars @@ -691,7 +703,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - engine: ['18.x', '20.x', 'xs'] + # TODO add 20.x after https://github.com/Agoric/agoric-sdk/issues/8636 + engine: ['18.x', 'xs'] steps: - name: set vars id: vars diff --git a/golang/cosmos/package.json b/golang/cosmos/package.json index 4efd5784343..d2a90c17744 100644 --- a/golang/cosmos/package.json +++ b/golang/cosmos/package.json @@ -7,7 +7,7 @@ }, "main": "src/index.cjs", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "test": "exit 0", diff --git a/package.json b/package.json index 6900038fd49..7ba78f4c5a4 100644 --- a/package.json +++ b/package.json @@ -37,7 +37,7 @@ "typescript": "~5.3.2" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "prettier": { "arrowParens": "avoid", diff --git a/packages/ERTP/package.json b/packages/ERTP/package.json index 02b483951a0..2771c567a78 100644 --- a/packages/ERTP/package.json +++ b/packages/ERTP/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/index.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/SwingSet/package.json b/packages/SwingSet/package.json index 4cbe3deda13..5b580d6291f 100644 --- a/packages/SwingSet/package.json +++ b/packages/SwingSet/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/index.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "bin": { "vat": "bin/vat" diff --git a/packages/assert/package.json b/packages/assert/package.json index d42532c1d70..7678d32511c 100755 --- a/packages/assert/package.json +++ b/packages/assert/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/assert.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/base-zone/package.json b/packages/base-zone/package.json index 155887c89c9..41c05ed76fb 100644 --- a/packages/base-zone/package.json +++ b/packages/base-zone/package.json @@ -40,7 +40,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [ diff --git a/packages/boot/package.json b/packages/boot/package.json index e839934e560..7bded3d9cc0 100644 --- a/packages/boot/package.json +++ b/packages/boot/package.json @@ -62,7 +62,7 @@ "exported.js" ], "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "extensions": { diff --git a/packages/builders/package.json b/packages/builders/package.json index b855b744967..ccf8b2c89e9 100644 --- a/packages/builders/package.json +++ b/packages/builders/package.json @@ -67,7 +67,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [ diff --git a/packages/cache/package.json b/packages/cache/package.json index 39209bcb604..9b7a9426ce8 100644 --- a/packages/cache/package.json +++ b/packages/cache/package.json @@ -35,7 +35,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [ diff --git a/packages/casting/package.json b/packages/casting/package.json index 50c0a3d6488..ccb713d5cea 100644 --- a/packages/casting/package.json +++ b/packages/casting/package.json @@ -50,7 +50,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [ diff --git a/packages/cosmic-swingset/package.json b/packages/cosmic-swingset/package.json index ef2dac3809f..de191b3e865 100644 --- a/packages/cosmic-swingset/package.json +++ b/packages/cosmic-swingset/package.json @@ -55,7 +55,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [ diff --git a/packages/deploy-script-support/package.json b/packages/deploy-script-support/package.json index 9579030f87d..16c307cd501 100644 --- a/packages/deploy-script-support/package.json +++ b/packages/deploy-script-support/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/helpers.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/governance/package.json b/packages/governance/package.json index ec3d4adf993..33121050ed5 100644 --- a/packages/governance/package.json +++ b/packages/governance/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/index.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "yarn build:bundles", diff --git a/packages/import-manager/package.json b/packages/import-manager/package.json index 60f48028199..163d0ca938e 100644 --- a/packages/import-manager/package.json +++ b/packages/import-manager/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "./src/importManager.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/inter-protocol/package.json b/packages/inter-protocol/package.json index 039b4c68dfa..274dd658546 100644 --- a/packages/inter-protocol/package.json +++ b/packages/inter-protocol/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/index.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "yarn build:bundles", diff --git a/packages/internal/package.json b/packages/internal/package.json index a6cc046576e..d6f975ab3f5 100755 --- a/packages/internal/package.json +++ b/packages/internal/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/index.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/network/package.json b/packages/network/package.json index 22a64893b93..0d2885e4c9e 100644 --- a/packages/network/package.json +++ b/packages/network/package.json @@ -51,7 +51,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [ diff --git a/packages/notifier/package.json b/packages/notifier/package.json index 7dd7f320ec8..36977ac0ca7 100644 --- a/packages/notifier/package.json +++ b/packages/notifier/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/index.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/pegasus/package.json b/packages/pegasus/package.json index 1b62ad318b5..dfcd0048973 100644 --- a/packages/pegasus/package.json +++ b/packages/pegasus/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "./src/pegasus.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/same-structure/package.json b/packages/same-structure/package.json index ba11eb08fef..fb4632f0776 100644 --- a/packages/same-structure/package.json +++ b/packages/same-structure/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "index.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/solo/package.json b/packages/solo/package.json index 60a9245a404..b2a66438264 100644 --- a/packages/solo/package.json +++ b/packages/solo/package.json @@ -65,7 +65,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [ diff --git a/packages/sparse-ints/package.json b/packages/sparse-ints/package.json index a249a1e6475..d4ce0677484 100644 --- a/packages/sparse-ints/package.json +++ b/packages/sparse-ints/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/sparseInts.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/spawner/package.json b/packages/spawner/package.json index 40f02ad3def..34678d7131b 100644 --- a/packages/spawner/package.json +++ b/packages/spawner/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "./src/contractHost.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "yarn build:bundles", diff --git a/packages/store/package.json b/packages/store/package.json index 9951fcd2f4b..1b712112b46 100644 --- a/packages/store/package.json +++ b/packages/store/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/index.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/swingset-liveslots/package.json b/packages/swingset-liveslots/package.json index f284301e778..1278669ef57 100644 --- a/packages/swingset-liveslots/package.json +++ b/packages/swingset-liveslots/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "src/index.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/telemetry/package.json b/packages/telemetry/package.json index 51de6255119..f1e053a9403 100644 --- a/packages/telemetry/package.json +++ b/packages/telemetry/package.json @@ -51,7 +51,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [ diff --git a/packages/time/package.json b/packages/time/package.json index 932733e9734..0210a74f457 100644 --- a/packages/time/package.json +++ b/packages/time/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "index.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "exit 0", diff --git a/packages/vat-data/package.json b/packages/vat-data/package.json index 170173affb7..4af68309587 100644 --- a/packages/vat-data/package.json +++ b/packages/vat-data/package.json @@ -42,7 +42,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "typeCoverage": { "atLeast": 98.23 diff --git a/packages/vats/package.json b/packages/vats/package.json index fe6bf69a5c3..fa078da9394 100644 --- a/packages/vats/package.json +++ b/packages/vats/package.json @@ -63,7 +63,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [ diff --git a/packages/vm-config/package.json b/packages/vm-config/package.json index 0600896afa6..2a38be9fbe5 100644 --- a/packages/vm-config/package.json +++ b/packages/vm-config/package.json @@ -36,7 +36,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [ diff --git a/packages/zoe/package.json b/packages/zoe/package.json index a9e3d74880f..a19b3ae505d 100644 --- a/packages/zoe/package.json +++ b/packages/zoe/package.json @@ -5,7 +5,7 @@ "type": "module", "main": "./src/zoeService/zoe.js", "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "scripts": { "build": "yarn build:bundles", diff --git a/packages/zone/package.json b/packages/zone/package.json index f160dc50280..455d0c56e5d 100644 --- a/packages/zone/package.json +++ b/packages/zone/package.json @@ -41,7 +41,7 @@ "access": "public" }, "engines": { - "node": "^18.12 || ^20.9" + "node": "^18.12" }, "ava": { "files": [