From 01e4ac29b9c9d7bda123cb337d71d139a9386db9 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Wed, 15 May 2024 09:22:30 -0700 Subject: [PATCH] ci: pack packages in PR tests --- .github/workflows/test-all-packages.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/test-all-packages.yml b/.github/workflows/test-all-packages.yml index 51e109e4c7e..29c1b529d3f 100644 --- a/.github/workflows/test-all-packages.yml +++ b/.github/workflows/test-all-packages.yml @@ -48,9 +48,23 @@ jobs: - name: Install graphviz run: sudo apt install -y graphviz + # This is now redundant with Lerna's --reject-cycles but keep it here so we have + # test coverage of this script we use for visualizing the dep graph. - name: Check for cycles run: scripts/check-dependency-cycles.sh + # install node_modules + - uses: ./.github/actions/restore-node + + # Releasing SDK builds all packages in this order during `lerna publish`. + # Due to ambient types, certain build orders (from the dependency graph) + # may break the type resolution. Run this in the PR to find out before + # attempting to merge to master. This takes about 1min locally and since + # this job is about 30s in CI doing it here doesn't add to wall wait + # for CI resolution. + - name: Pack packages + run: yarn lerna exec --reject-cycles --concurrency 1 "npm pack" + ################## # Lint tests # We run per package bc of https://github.com/typescript-eslint/typescript-eslint/issues/1192