chore: remove netstat debugging #126
Conversation
|
Curiously, removing the debugging output re-triggered the error I thought was fixed: |
turadg
force-pushed
the
93-port-debugging
branch
4 times, most recently
from
a9f68bc to
f6b824c
Compare
| # XXX debugging https://github.com/Agoric/agoric-3-proposals/issues/93 | ||
| apt install net-tools | ||
| netstat | ||
| # precondition check |
There was a problem hiding this comment.
| # precondition check | |
| # XXX debugging https://github.com/Agoric/agoric-3-proposals/issues/93 | |
| apt install net-tools | |
| netstat -plnA inet | |
| # precondition check |
There was a problem hiding this comment.
This PR is to remove the netstat debugging. The underlying cause is that agd is already bound to the ports. I don't know the cause of that but this hacks around it by waiting for it to die.
There was a problem hiding this comment.
Right, I'm trying to get to the bottom of that with a more useful invocation of netstat.
There was a problem hiding this comment.
Oh, I thought you were suggesting a change in this PR. If you want to figure out the cause of failures in #127 I thought you'd push to that branch whatever logging you need.
There was a problem hiding this comment.
I'm putting this up for review again because I think we should keep those netstat logs out of main. They make the logs unwieldy to scroll in the Github UI
turadg
force-pushed
the
93-port-debugging
branch
from
9f47b9e to
2702852
Compare
turadg
force-pushed
the
93-port-debugging
branch
from
2702852 to
1a0becb
Compare
|
merging without review to help debug trunk. |
refs: #93
We haven't seen that flake since the hypothesized fix #93 (comment)
The debugging output of
netstatcauses the logs to grow too large for Github's UI to search them. So let's not wait any longer to remove the output.I don't think this will really solve #93 so this doesn't close it