From e281daf867217dc4bf70bf4631a46a21e873d4ce Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Thu, 24 Oct 2024 09:57:05 -0700 Subject: [PATCH 1/2] Create pull_request_template.md --- .github/pull_request_template.md | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..a3a0084e --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,29 @@ + + +Closes # + +# adopt a passed proposal +When a proposal passes on agoric-3 Mainnet, it should be included in the history that this synthetic image tracks. + +- [ ] before this PR, change any `fromTag` using `latest` (such as [a3p-integration](https://github.com/Agoric/agoric-sdk/blob/master/a3p-integration/package.json)) to use a fixed version (otherwise they will fail when this PR changes latest and they pick it up) +- [ ] before merging this PR, include a link to a PR that restores `latest` +- [ ] after this PR merges, merge the other PRs so they're back on `latest` + +## image building process + +This should not affect other repos but be prepared that it might. + +## @agoric/synthetic-chain library +These need to be published to be consumed in other apps. It's not yet on 1.0 so breaking changes are allowed, but please don't make them gratuitously. + +- [ ] indicate in the PR description when you expect these to be published and by whom (it's currently a manual process) + +## tooling improvements + +As long as it passes CI it should be fine. + From 290040d1e8dfe10bc37ab0497a663708b64e6b89 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Thu, 24 Oct 2024 12:36:27 -0700 Subject: [PATCH 2/2] docs: use fixed image in other repos Co-authored-by: Richard Gibson --- .github/pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a3a0084e..cc451941 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,8 +11,8 @@ Closes # When a proposal passes on agoric-3 Mainnet, it should be included in the history that this synthetic image tracks. - [ ] before this PR, change any `fromTag` using `latest` (such as [a3p-integration](https://github.com/Agoric/agoric-sdk/blob/master/a3p-integration/package.json)) to use a fixed version (otherwise they will fail when this PR changes latest and they pick it up) -- [ ] before merging this PR, include a link to a PR that restores `latest` -- [ ] after this PR merges, merge the other PRs so they're back on `latest` +- [ ] before merging this PR, include a link to a PR that adopts its fromTag `use-${proposalName}` (where proposalName is the part of the agoric-3-proposals proposal directory name after the colon, cf. [a3p-integration/proposals](https://github.com/Agoric/agoric-sdk/tree/master/a3p-integration/proposals#how-to-revise-this-directory-after)) +- [ ] after this PR merges, merge that other PR ## image building process