From a5f5cf925c105477963a56373fa05b2da82eab63 Mon Sep 17 00:00:00 2001 From: Alejandro Esquivel Date: Thu, 10 Aug 2023 06:45:07 -0700 Subject: [PATCH] Using nvmrc for node version in tests workflow (#1744) --- .github/workflows/tests.yml | 6 ++++++ CHANGELOG.md | 1 + 2 files changed, 7 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 7674fd121..d18a6c170 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -164,6 +164,12 @@ jobs: pip install --no-cache-dir -r ./requirements.txt pip install --no-cache-dir -r ./tests/requirements.txt + - name: Set up Node + if: env.NEED_FRONTEND || env.BUILD_AND_RUN_ALL + uses: actions/setup-node@v3 + with: + node-version-file: 'covalent_ui/webapp/.nvmrc' + - name: Build webapp if: env.NEED_FRONTEND || env.BUILD_AND_RUN_ALL uses: nick-fields/retry@v2 diff --git a/CHANGELOG.md b/CHANGELOG.md index 06610d0aa..c8636c956 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Operations +- Respecting node version as specified in `.nvmrc` file for tests workflow - Bumped versions in pre-commit config - Added prettier for markdown files. - Reduce the number of pinned version numbers in the `setup.py`, `requirements.txt`, and `requirements-client.txt`