Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tool env #26

Closed
bboynton97 opened this issue Oct 28, 2024 · 0 comments
Closed

refactor tool env #26

bboynton97 opened this issue Oct 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@bboynton97
Copy link
Contributor

Currently when you add a new tool, in <tool_name>.json, you have an env property.

{
    "name": "agent-connect",
    "package": "poetry add agent-connect",
    "env": "HOST_DOMAIN=...\nHOST_PORT=\"80\"\nHOST_WS_PATH=\"/ws\"\nDID_DOCUMENT_PATH=...\nSSL_CERT_PATH=...\nSSL_KEY_PATH=...",
    "tools": ["send_message", "receive_message"]
}

this is too rigidly designed. instead, lets accept a list of strings and handle the new line in the code. instead, this should look like

{
    "name": "agent-connect",
    "package": "poetry add agent-connect",
    "env": 
        [
            "HOST_DOMAIN",
            "HOST_PORT=\"80\"",
            "HOST_WS_PATH=\"/ws\"",
            "DID_DOCUMENT_PATH=...",
            "SSL_CERT_PATH=...",
            "SSL_KEY_PATH=..."
        ],
    "tools": ["send_message", "receive_message"]
}

change the current tool configs to match

@bboynton97 bboynton97 added the enhancement New feature or request label Oct 28, 2024
tcdent added a commit to tcdent/AgentStack that referenced this issue Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant