Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open/Click events #84

Closed
malas opened this issue Sep 17, 2018 · 5 comments
Closed

Add Open/Click events #84

malas opened this issue Sep 17, 2018 · 5 comments

Comments

@malas
Copy link

malas commented Sep 17, 2018

NotificationProcessor.php should also process the open and click Notifications from AWS and dispatch corresponding symfony events.

Ping #64

@Aerendir
Copy link
Owner

Hi @malas , thank you for highlighting this!

I'm in the process of better understanding how the system works and how to implement it.

This is not as simple as reading the responses from Amazon, but requires to think also at the way the bundle handles the configuration of topics.

Without speaking about GDPR, that for sure is not something that the bundle should take into account. But, as the bundle will make a lot easier to configure the tracking features, a mention, also if very small, should be done.

Are you able to implement this feature?

@Aerendir Aerendir added this to the 2.2 - Dispatch events milestone Sep 24, 2018
@malas
Copy link
Author

malas commented Sep 24, 2018

After examining your bundle we have decided to roll our own solution.

The main difference is that our solution will only emit a coresponding symfony event on SNS notification an then one can hook any logic he wants.

@Aerendir
Copy link
Owner

Ok, as you like.

Just to understand better, if you like to answer me: currently, the bundle doesn't emit any event: this is a planned feature that will be released very soon.

Once the bundle will emit the Symfony events, which will be the difference with your own solution?

@malas
Copy link
Author

malas commented Sep 24, 2018 via email

@Aerendir
Copy link
Owner

Ok, I understand your point. Anyway, thank you for your comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants