Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch some events #31

Closed
dextervip opened this issue Jun 18, 2018 · 9 comments
Closed

Dispatch some events #31

dextervip opened this issue Jun 18, 2018 · 9 comments

Comments

@dextervip
Copy link

Hey,

It would be nice to dispatch some events about bounces, complaints so that we can subscribe to make extra treatments in our app.

Regards

@Aerendir
Copy link
Owner

Hi @dextervip , this is a good idea...

In some days I will update the bundle to make it better, adding some new functionalities and generally improving the code.

I'd appreciate a lot if you could expand this suggestion with some use cases you like to get covered, so I can implement a better event system...

@Aerendir Aerendir added this to the 2.0 milestone Jul 7, 2018
@Aerendir Aerendir self-assigned this Jul 7, 2018
@Aerendir Aerendir removed their assignment Jul 7, 2018
@dextervip
Copy link
Author

Well my case use would be to listen events when emails are hard bounced and update my customer personal info entity to flag this email as invalid so my system stops sending and my agents know this is an invalid contact.

@Aerendir
Copy link
Owner

Ok, I understand your point...

I'm deeply refactoring the bundle and adding new features: this will be added in the version 2.0.

I hope in a couple of weeks to finish...

@Aerendir
Copy link
Owner

Aerendir commented Jul 12, 2018

Tracked by #64 to make GitHub able to calculate the progress.

@dextervip
Copy link
Author

Awesome! At moment, as a workaround I had to override the entire handle class (all methods are private so i couldn't override the specific method I needed, idk maybe refactor to protected would be good also).

@Aerendir
Copy link
Owner

@dextervip , I've completely refactored the handlers: check the new code that should be more clear to understand.

Start from the EndpointController and it will guide you down towards the handlers...

Any feedback about the new code is welcome!

@drzraf
Copy link

drzraf commented Nov 9, 2018

Hi,
I've the same need. There like a blackhole in the documentation after "4. Test-dev.md", because "5. Using" is only about "collected" information and not reacting to endpoint requests.

I would expect to process the bounces notifications in real time and, for that, having a controller somehow listening to these events. I can't find examples of this.

@Aerendir
Copy link
Owner

Aerendir commented Nov 9, 2018

@drzraf, the events are not fired in this moment.

I deeply refactored the bundle and introduced a completely revamped command to configure the app with AWS SES.

I plan to add the events in the next minor version.

Any help on this, anyway, will be welcome!

The main issue for this is this #64

I plan to add at least 5 events. More info in the linked issue.

@Aerendir
Copy link
Owner

Aerendir commented Nov 9, 2018

PS The documentation is not still updated: I'm updating it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants