Fix parseInt() radix

Adyen · Jan 18, 2023 · ac9b3d8 · ac9b3d8
1 parent 8cc1970
commit ac9b3d8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/Resources/app/storefront/src/cart/cart.plugin.js b/src/Resources/app/storefront/src/cart/cart.plugin.js
@@ -59,7 +59,7 @@ export default class CartPlugin extends Plugin {
             this.removeGiftcard();
         }.bind(this));
 
-        if (parseInt(adyenGiftcardsConfiguration.giftcardDiscount)) {
+        if (parseInt(adyenGiftcardsConfiguration.giftcardDiscount, 10)) {
             this.onGiftcardSelected();
         }
     }

diff --git a/src/Resources/app/storefront/src/checkout/confirm-order.plugin.js b/src/Resources/app/storefront/src/checkout/confirm-order.plugin.js
@@ -72,8 +72,8 @@ export default class ConfirmOrderPlugin extends Plugin {
             }
         }.bind(this));
 
-        if (parseInt(adyenCheckoutOptions.payInFullWithGiftcard)) {
-            if (parseInt(adyenCheckoutOptions.adyenGiftcardSelected)) {
+        if (parseInt(adyenCheckoutOptions.payInFullWithGiftcard, 10)) {
+            if (parseInt(adyenCheckoutOptions.adyenGiftcardSelected, 10)) {
                 this.appendGiftcardSummary();
             }
         } else {
@@ -193,7 +193,10 @@ export default class ConfirmOrderPlugin extends Plugin {
     }
 
     createOrder(formData, extraParams) {
-        if (parseInt(adyenCheckoutOptions.giftcardDiscount) && !parseInt(adyenCheckoutOptions.payInFullWithGiftcard)) {
+        if (
+            parseInt(adyenCheckoutOptions.giftcardDiscount, 10) &&
+            !parseInt(adyenCheckoutOptions.payInFullWithGiftcard, 10)
+        ) {
             // create Adyen order for partial payments
             this._client.post(
                 adyenCheckoutOptions.createOrderUrl,
@@ -553,7 +556,7 @@ export default class ConfirmOrderPlugin extends Plugin {
     }
 
     appendGiftcardSummary() {
-        if(parseInt(adyenCheckoutOptions.giftcardDiscount) && this.shoppingCartSummaryBlock.length) {
+        if(parseInt(adyenCheckoutOptions.giftcardDiscount, 10) && this.shoppingCartSummaryBlock.length) {
             this.shoppingCartSummaryDetails = $('<dt class="col-7 checkout-aside-summary-label checkout-aside-summary-total adyen-giftcard-summary">Giftcard discount</dt>' +
                 '<dd class="col-5 checkout-aside-summary-value checkout-aside-summary-total adyen-giftcard-summary">' + adyenCheckoutOptions.currencySymbol + this.giftcardDiscount + '</dd>' +
                 '<dt class="col-7 checkout-aside-summary-label checkout-aside-summary-total adyen-giftcard-summary">Remaining amount</dt>' +