Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Functionality: Creation of dynamic property $adyenHelper is deprecated #2750

Closed
adamkarnowka opened this issue Sep 19, 2024 · 2 comments · Fixed by #2743
Closed
Assignees
Labels
Bug report Indicates that issue has been marked as a possible bug

Comments

@adamkarnowka
Copy link

Hello - There is an error in the file:
https://github.com/Adyen/adyen-magento2/blob/main/Model/Resolver/StoreConfig/StoreLocale.php#L27

Describe the bug
When graphql schema is fetched, it cannot fetch because of error:

Deprecated Functionality: Creation of dynamic property Adyen\Payment\Model\Resolver\StoreConfig\StoreLocale\Interceptor::$adyenHelper is deprecated in /app/xxxxxxxxxxx/vendor/adyen/module-payment/Model/Resolver/StoreConfig/StoreLocale.php on line 35

Because property is called protected Data $dataHelper; while in constructor you are using $this->adyenHelper = $adyenHelper; (dataHelper != adyenHelper)

To Reproduce

  1. Have latest version installed and php8.2
  2. Try to fetch graphql schema:
{
    __schema {
        types {
            __typename
        }
    }
}

Expected behavior
Schema is fetched without errors

Magento version
2.4.6-p7

Plugin version
9.8.1

Screenshots
image

@adamkarnowka adamkarnowka added the Bug report Indicates that issue has been marked as a possible bug label Sep 19, 2024
@dimitriBouteille
Copy link
Contributor

🚀 #2743

@candemiralp candemiralp self-assigned this Sep 27, 2024
@candemiralp
Copy link
Member

Hello @adamkarnowka and @dimitriBouteille ,

Thank you for reporting this issue and providing a fix. The fix will be merged.

Best Regards,
Can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Indicates that issue has been marked as a possible bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants