Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card component bottom sheet improvements #313

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Card component bottom sheet improvements #313

merged 8 commits into from
Nov 26, 2024

Conversation

Robert-SD
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

LCOV of commit f156d50 during Check PR #946

Summary coverage rate:
  lines......: 10.6% (136 of 1289 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/card/base_card_component.dart                                              | 0.0%     65|    -     0|    -      0
  lib/src/components/card/card_advanced_component.dart                                          | 0.0%     50|    -     0|    -      0
  lib/src/components/card/card_component_container.dart                                         | 0.0%     19|    -     0|    -      0
  lib/src/components/card/card_session_component.dart                                           | 0.0%     18|    -     0|    -      0

@github-actions GitHub Actions
Copy link

LCOV of commit d465ac6 during Check PR #947

Summary coverage rate:
  lines......: 10.5% (136 of 1291 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/card/base_card_component.dart                                              | 0.0%     67|    -     0|    -      0
  lib/src/components/card/card_advanced_component.dart                                          | 0.0%     50|    -     0|    -      0
  lib/src/components/card/card_component_container.dart                                         | 0.0%     19|    -     0|    -      0
  lib/src/components/card/card_session_component.dart                                           | 0.0%     18|    -     0|    -      0

@github-actions GitHub Actions
Copy link

LCOV of commit 494119a during Check PR #948

Summary coverage rate:
  lines......: 10.5% (136 of 1291 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/card/base_card_component.dart                                              | 0.0%     67|    -     0|    -      0
  lib/src/components/card/card_advanced_component.dart                                          | 0.0%     50|    -     0|    -      0
  lib/src/components/card/card_component_container.dart                                         | 0.0%     19|    -     0|    -      0
  lib/src/components/card/card_session_component.dart                                           | 0.0%     18|    -     0|    -      0

@github-actions GitHub Actions
Copy link

LCOV of commit 66e46fe during Check PR #949

Summary coverage rate:
  lines......: 10.5% (136 of 1291 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/card/base_card_component.dart                                              | 0.0%     67|    -     0|    -      0
  lib/src/components/card/card_advanced_component.dart                                          | 0.0%     50|    -     0|    -      0
  lib/src/components/card/card_component_container.dart                                         | 0.0%     19|    -     0|    -      0
  lib/src/components/card/card_session_component.dart                                           | 0.0%     18|    -     0|    -      0

@github-actions GitHub Actions
Copy link

LCOV of commit 75cb811 during Check PR #950

Summary coverage rate:
  lines......: 10.5% (136 of 1291 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/card/base_card_component.dart                                              | 0.0%     67|    -     0|    -      0
  lib/src/components/card/card_advanced_component.dart                                          | 0.0%     50|    -     0|    -      0
  lib/src/components/card/card_component_container.dart                                         | 0.0%     19|    -     0|    -      0
  lib/src/components/card/card_session_component.dart                                           | 0.0%     18|    -     0|    -      0

@Robert-SD Robert-SD marked this pull request as ready for review November 25, 2024 14:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Robert-SD Robert-SD linked an issue Nov 26, 2024 that may be closed by this pull request
Card button gets partially hidden when there are errors in the form #309
Closed
@Robert-SD Robert-SD merged commit 5301aba into main Nov 26, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@descorp descorp descorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Card button gets partially hidden when there are errors in the form
2 participants
@Robert-SD @descorp