Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline handling for AdyenComponent #256

Open
drekyyy opened this issue Aug 30, 2024 · 1 comment
Open

Offline handling for AdyenComponent #256

drekyyy opened this issue Aug 30, 2024 · 1 comment
Assignees
Labels
enhancement Indicates new feature requests good first issue Good for newcomers

Comments

@drekyyy
Copy link

drekyyy commented Aug 30, 2024

Describe the bug
A clear and concise description of what the bug is.

I am testing offline cases for adyen card component and stumbled upon few issues (probably reproducible for gpay and applepay):
Issue 1:
Have no internet connection -> navigate to AdyenCardComponent -> get this PaymentResult:
Instance of 'PaymentError', reason: com.adyen.checkout.core.exception.ComponentException: Unable to fetch publicKey.

Issue 2:
Be online -> navigate to AdyenCardComponent -> drop internet connection -> submit correct card details -> get this PaymentResult:
Instance of 'PaymentError', reason: Null check operator used on a null value

Expected behavior

If possible Id want the PaymentResult to be of certain type clearly indicating what went wrong

@drekyyy drekyyy changed the title Offline/timeout handling for AdyenComponent Offline handling for AdyenComponent Aug 30, 2024
@Robert-SD Robert-SD self-assigned this Sep 2, 2024
@Robert-SD
Copy link
Collaborator

Hello @drekyyy,
thanks for pointing out the two issues. Having a result that clearly indicates what went wrong is indeed the right expected behavior. I will look into it and create a task for adding the checks.

As a spontaneous idea for the advanced flow integration: By adding a connectivity check and providing an Error PaymentEvent within the onSubmit and onAdditionalDetails callback could be a solution. But I will check this as well and would like to keep this ticket open for further collaboration.

@Robert-SD Robert-SD added enhancement Indicates new feature requests good first issue Good for newcomers labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants