Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pay by Bank US #1899

Merged
merged 24 commits into from
Dec 3, 2024
Merged

Pay by Bank US #1899

merged 24 commits into from
Dec 3, 2024

Conversation

ozgur00
Copy link
Contributor

@ozgur00 ozgur00 commented Nov 25, 2024 •
edited
Loading

Description

Pay by Bank US payment method.

Checklist

  • PR is labelled
  • Code is unit tested
  • Changes are tested manually

COAND-974

@ozgur00 ozgur00 added the Feature [PRs only] Indicates a new feature addition label Nov 25, 2024
@ozgur00 ozgur00 force-pushed the feature/pay-by-bank-us branch from 393fb34 to fd524d3 Compare November 25, 2024 13:08
@ozgur00 ozgur00 marked this pull request as ready for review November 25, 2024 13:39
@ozgur00 ozgur00 requested a review from a team as a code owner November 25, 2024 13:39
@ozgur00 ozgur00 force-pushed the feature/pay-by-bank-us branch from fd524d3 to 432950c Compare November 26, 2024 14:47
@ozgur00 ozgur00 force-pushed the feature/pay-by-bank-us branch 2 times, most recently from 5e1499d to 88e45ce Compare December 3, 2024 09:28
ozgur00 added 22 commits December 3, 2024 15:23
@ozgur00
Create paybybank-us module
33439dc 
COAND-974
@ozgur00
Create paybybank-us component files
0bd9e3d 
COAND-974
@ozgur00
Implement PayByBankUSConfiguration
9d512ce 
COAND-974
@ozgur00
Add PayByBankUSConfigurationTest
00a3443 
COAND-974
@ozgur00
Implement paybybank-us component, delegate and component state classes
3e75f74 
COAND-974
@ozgur00
Implement PayByBankUSComponentProvider
7fca1df 
COAND-974
@ozgur00
Implement PayByBankUSComponent
be47252 
COAND-974
@ozgur00
Implement DefaultPayByBankUSDelegate
ab1518c 
COAND-974
@ozgur00
Implement ui for PayByBankUSComponent
3bc8c1e 
COAND-974
@ozgur00
Include paybybank-us module in drop-in
638f9b1 
COAND-974
@ozgur00
Display brand logos on PayByBankUS item in payment methods list
978e98d 
COAND-974
@ozgur00
Add PayByBankUSComponentTest
759504d 
COAND-974
@ozgur00
Add DefaultPayByBankUSDelegateTest
0d3a893 
COAND-974
@ozgur00
Display 4 logos on drop-in payment methods list for Pay by Bank US
d1b2871 
COAND-974
@ozgur00
Add release notes for PayByBankUSComponent
79a5aaf 
COAND-974
@ozgur00
Add Pay by Bank US to supported payment method types
7830bca 
COAND-974
@ozgur00
Add StoredPayByBankUSDelegate
024ee01 
COAND-974
@ozgur00
Add display logic for Pay by Bank US using label in stored payment me…
ec9e6ed 
…thods section

COAND-974
@ozgur00
Initialize analytics in StoredPayByBankUSDelegate
fcaba3a 
COAND-974
@ozgur00
Add StoredPayByBankUSDelegateTest
cebe3f7 
COAND-974
@ozgur00
Remove unnecessary dependencies from StoredPayByBankUSDelegate
5534bf7 
COAND-974
@ozgur00
Display Pay by Bank account name in stored payment confirmation pop-up
77f9a41 
COAND-974
@ozgur00 ozgur00 force-pushed the feature/pay-by-bank-us branch from 88e45ce to 6c5c8da Compare December 3, 2024 14:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

✅ No public API changes

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
59.8% Coverage on New Code (required ≥ 80%)
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ozgur00 ozgur00 merged commit 7d25d47 into develop Dec 3, 2024
11 of 12 checks passed
@ozgur00 ozgur00 deleted the feature/pay-by-bank-us branch December 3, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreij jreij jreij left review comments

@OscarSpruit OscarSpruit OscarSpruit approved these changes

Assignees
No one assigned
Labels
Feature [PRs only] Indicates a new feature addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ozgur00 @jreij @OscarSpruit