Clean up old tests where we check the message for analytics events

COAND-1010
Adyen · Dec 11, 2024 · 1386c37 · 1386c37
1 parent f36ca33
commit 1386c37
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/3ds2/src/main/java/com/adyen/checkout/adyen3ds2/internal/ui/DefaultAdyen3DS2Delegate.kt b/3ds2/src/main/java/com/adyen/checkout/adyen3ds2/internal/ui/DefaultAdyen3DS2Delegate.kt
@@ -623,10 +623,10 @@ internal class DefaultAdyen3DS2Delegate(
     }
 
     private fun trackFingerprintActionEvent(action: Action) =
-        trackActionEvent(action, ANALYTICS_MESSAGE_FINGERPRINT)
+        trackActionEvent(action, "Fingerprint action was handled by the SDK")
 
     private fun trackChallengeActionEvent(action: Action) =
-        trackActionEvent(action, ANALYTICS_MESSAGE_CHALLENGE)
+        trackActionEvent(action, "Challenge action was handled by the SDK")
 
     private fun trackActionEvent(action: Action, message: String) {
         val event = GenericEvents.action(
@@ -740,13 +740,6 @@ internal class DefaultAdyen3DS2Delegate(
     }
 
     companion object {
-        @VisibleForTesting
-        internal const val ANALYTICS_MESSAGE_FINGERPRINT =
-            "Fingerprint action was handled by the SDK"
-
-        @VisibleForTesting
-        internal const val ANALYTICS_MESSAGE_CHALLENGE = "Challenge action was handled by the SDK"
-
         private const val DEFAULT_CHALLENGE_TIME_OUT = 10
         private const val PROTOCOL_VERSION_2_1_0 = "2.1.0"
 

diff --git a/3ds2/src/test/java/com/adyen/checkout/adyen3ds2/internal/ui/DefaultAdyen3DS2DelegateTest.kt b/3ds2/src/test/java/com/adyen/checkout/adyen3ds2/internal/ui/DefaultAdyen3DS2DelegateTest.kt
@@ -548,7 +548,6 @@ internal class DefaultAdyen3DS2DelegateTest(
             val expectedEvent = GenericEvents.action(
                 component = TEST_PAYMENT_METHOD_TYPE,
                 subType = TEST_ACTION_TYPE,
-                message = DefaultAdyen3DS2Delegate.ANALYTICS_MESSAGE_FINGERPRINT,
             )
             analyticsManager.assertHasEventEquals(expectedEvent)
         }
@@ -567,7 +566,6 @@ internal class DefaultAdyen3DS2DelegateTest(
             val expectedEvent = GenericEvents.action(
                 component = TEST_PAYMENT_METHOD_TYPE,
                 subType = TEST_ACTION_TYPE,
-                message = DefaultAdyen3DS2Delegate.ANALYTICS_MESSAGE_CHALLENGE,
             )
             analyticsManager.assertHasEventEquals(expectedEvent)
         }
@@ -587,7 +585,6 @@ internal class DefaultAdyen3DS2DelegateTest(
             val expectedEvent = GenericEvents.action(
                 component = TEST_PAYMENT_METHOD_TYPE,
                 subType = TEST_ACTION_TYPE,
-                message = DefaultAdyen3DS2Delegate.ANALYTICS_MESSAGE_FINGERPRINT,
             )
             analyticsManager.assertHasEventEquals(expectedEvent)
         }
@@ -607,7 +604,6 @@ internal class DefaultAdyen3DS2DelegateTest(
             val expectedEvent = GenericEvents.action(
                 component = TEST_PAYMENT_METHOD_TYPE,
                 subType = TEST_ACTION_TYPE,
-                message = DefaultAdyen3DS2Delegate.ANALYTICS_MESSAGE_CHALLENGE,
             )
             analyticsManager.assertHasEventEquals(expectedEvent)
         }