Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring, more readable and easier to modify #736

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

Angel-Karasu
Copy link
Contributor

@Angel-Karasu Angel-Karasu commented Jul 9, 2024

Add

Global variables

Reduce the number of processor calculations and easier to modify because only one change is needed instead of several

Remove

Breaklines

Easier to modify because shorter code is more readable

Empty __init__.py files

Empty so useless

--log flag

The --log flag has been renamed to --stats

Rename

utils folder to config folder

Easier to modify because more orderly folders

Sort

Flags

Easier to modify because more orderly code

Imports and variables alphabetically

Easier to modify because more orderly and readable code

Uses

from pkg import objects instead of import pkg

Easier to modify because more readable code

@Angel-Karasu Angel-Karasu changed the title Clean code to be more readable and simply to modify Clean code to be more readable and easier to modify Jul 9, 2024
@Angel-Karasu Angel-Karasu changed the title Clean code to be more readable and easier to modify Code refactoring Jul 13, 2024
@Angel-Karasu Angel-Karasu changed the title Code refactoring Code refactoring, more readable Jul 13, 2024
@Angel-Karasu Angel-Karasu changed the title Code refactoring, more readable Code refactoring, more readable and easier to modify Jul 13, 2024
@@ -1,88 +1,73 @@
diff --git a/auto_cpufreq/core.py b/auto_cpufreq/core.py
index 99397a9..16869ab 100755
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadeyg56 if you could also check Nix part since I don't use it that would be great, thanks!

@AdnanHodzic
Copy link
Owner

After thoroughly testing the changes, I'm happy to say LGTM!

Thank you for your contribution, you will be credited for your work as part of future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants