-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactoring, more readable and easier to modify #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angel-Karasu
changed the title
Clean code to be more readable and simply to modify
Clean code to be more readable and easier to modify
Jul 9, 2024
Angel-Karasu
changed the title
Clean code to be more readable and easier to modify
Code refactoring
Jul 13, 2024
Angel-Karasu
changed the title
Code refactoring, more readable
Code refactoring, more readable and easier to modify
Jul 13, 2024
AdnanHodzic
reviewed
Jul 15, 2024
AdnanHodzic
reviewed
Jul 15, 2024
AdnanHodzic
reviewed
Jul 15, 2024
AdnanHodzic
reviewed
Jul 15, 2024
AdnanHodzic
reviewed
Jul 15, 2024
AdnanHodzic
reviewed
Jul 15, 2024
AdnanHodzic
reviewed
Jul 15, 2024
@@ -1,88 +1,73 @@ | |||
diff --git a/auto_cpufreq/core.py b/auto_cpufreq/core.py | |||
index 99397a9..16869ab 100755 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadeyg56 if you could also check Nix part since I don't use it that would be great, thanks!
After thoroughly testing the changes, I'm happy to say LGTM! Thank you for your contribution, you will be credited for your work as part of future release. |
This was referenced Jul 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Global variables
Reduce the number of processor calculations and easier to modify because only one change is needed instead of several
Remove
Breaklines
Easier to modify because shorter code is more readable
Empty
__init__.py
filesEmpty so useless
--log
flagThe
--log
flag has been renamed to--stats
Rename
utils
folder toconfig
folderEasier to modify because more orderly folders
Sort
Flags
Easier to modify because more orderly code
Imports and variables alphabetically
Easier to modify because more orderly and readable code
Uses
from pkg import objects
instead ofimport pkg
Easier to modify because more readable code