Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More compatible for Arch based distributions #691

Merged
merged 9 commits into from
May 9, 2024
Merged

More compatible for Arch based distributions #691

merged 9 commits into from
May 9, 2024

Conversation

Angel-Karasu
Copy link
Contributor

Change the method to detect if it's an Arch based distribution

@AdnanHodzic
Copy link
Owner

Since I don't use Arch would like to hear what auto-cpufreq AUR package maintainers thing about these changes.

@MusicalArtist12 @liljaylj and @Parmjot-Singh

@Angel-Karasu
Copy link
Contributor Author

All Arch based distributions use Arch repos (except Manjaro, but it's the same packages with a bit of a delay for better stability) so there shouldn't be any problem.

@MusicalArtist12
Copy link
Contributor

I mean, I don't see how it really changes, the original installer does work on arch linux, and it doesn't change the installer's logic in terms of what packages it installs to the system via pacman. I don't see anything wrong with it, I just think its superfluous. I also think the dinit support should be added through a separate pull request, since arch uses systemd anyways.

@MusicalArtist12
Copy link
Contributor

to contradict myself, The one change moving arch detection out of /etc/os-release does make sense. Its fine, as long as the readme changes make sense.

@MusicalArtist12
Copy link
Contributor

MusicalArtist12 commented May 9, 2024

should also be mentioned that the AUR build uses python -m build --wheel --no-isolation and python -m installer --destdir="$pkgdir" dist/*.whl instead of the installer script to create a package that is then natively installed, So the changes to this don't affect that, since dependencies are handled by the arch build system.

@AdnanHodzic
Copy link
Owner

@Angel-Karasu could you then please also update Readme file as @MusicalArtist12 suggested, just so we avoid any ambiguity, thanks!

@Angel-Karasu
Copy link
Contributor Author

I don't understand what I should add in the README because if the AUR package works on Arch I don't see why it wouldn't work on Arch based distributions

@MusicalArtist12
Copy link
Contributor

I might've just misread the latest diff if that's the only change then. otherwise this looks good to me. I can separately create a PR that mentions that the AUR build doesn't use the installer.

@Angel-Karasu
Copy link
Contributor Author

The AUR package does not change and should normally already work on all Arch-based distributions. My change is to the installer, I'm just changing the way it detects the distribution, instead of using /etc/os-release, it checks if there is a /etc/arch-release file that is present on all Arch-based distributions.

@AdnanHodzic
Copy link
Owner

I might've just misread the latest diff if that's the only change then. otherwise this looks good to me. I can separately create a PR that mentions that the AUR build doesn't use the installer.

@MusicalArtist12 sounds good to me, separate PR for README update works for me. Maybe also a good idea to include/mention @Angel-Karasu under AUR/Arch section in case of questions, unless they are objections from @Angel-Karasu side.

@Angel-Karasu changes LGTM. Thank you for your contribution, you will be credited for your work as part of future release.

@AdnanHodzic AdnanHodzic merged commit eb0ba8a into AdnanHodzic:master May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants