From 3b1a90898550483cc410a9536ec96457b4c8d171 Mon Sep 17 00:00:00 2001 From: sho ishihara Date: Mon, 28 Oct 2019 16:12:19 +0900 Subject: [PATCH 1/2] add vcm attr to banner --- banner.go | 1 + 1 file changed, 1 insertion(+) diff --git a/banner.go b/banner.go index 8967a82..5468626 100644 --- a/banner.go +++ b/banner.go @@ -24,5 +24,6 @@ type Banner struct { TopFrame int `json:"topframe,omitempty"` // Default: 0 ("1": Delivered in top frame, "0": Elsewhere) ExpDir []int `json:"expdir,omitempty"` // Specify properties for an expandable ad Api []int `json:"api,omitempty"` // List of supported API frameworks + Vcm int `json:"vcm,omitempty"` // Represents the relationship with video. 0 = concurrent, 1 = end-card Ext json.RawMessage `json:"ext,omitempty"` } From 75ebdae16fbfcd6a38c67ecb8acd4a2a0b610d99 Mon Sep 17 00:00:00 2001 From: sho ishihara Date: Mon, 28 Oct 2019 18:23:14 +0900 Subject: [PATCH 2/2] fix banner test for vcm --- banner_test.go | 1 + testdata/banner.json | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/banner_test.go b/banner_test.go index a8f8787..f982d2b 100644 --- a/banner_test.go +++ b/banner_test.go @@ -21,6 +21,7 @@ var _ = Describe("Banner", func() { BType: []int{BannerTypeFrame}, BAttr: []int{CreativeAttributeWindowsDialogOrAlert}, Api: []int{APIFrameworkMRAID1}, + Vcm: 1, })) }) diff --git a/testdata/banner.json b/testdata/banner.json index 245fb14..4a64ce9 100644 --- a/testdata/banner.json +++ b/testdata/banner.json @@ -10,5 +10,6 @@ ], "api": [ 3 - ] + ], + "vcm": 1 }