Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows permission checks #7314

Closed
4 tasks done
ainar-g opened this issue Oct 3, 2024 · 0 comments
Closed
4 tasks done

Improve Windows permission checks #7314

ainar-g opened this issue Oct 3, 2024 · 0 comments

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Oct 3, 2024

Prerequisites

Platform (OS and CPU architecture)

Windows, AMD64 (aka x86_64)

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.107.53

Action

In v0.107.53 we have added a migration that should automatically detect and fix lax permissions on files on Unix-like systems. Unfortunately, the poor support of the Windows permission model from the standard Go library prevented us from doing the same on Windows.

We must find or develop libraries to make the migration and these mitigations work on Windows, as well just generally allow us to control file permissions properly.

Expected result

v0.107.53 fixes applied automatically on Windows.

Actual result

v0.107.53 fixes are not applied automatically on Windows.

Additional information and/or screenshots

No response

@ainar-g ainar-g added this to the v0.107.54 milestone Oct 3, 2024
@ainar-g ainar-g pinned this issue Oct 3, 2024
@EugeneOne1 EugeneOne1 modified the milestones: v0.107.55, v0.107.54 Oct 29, 2024
adguard pushed a commit that referenced this issue Nov 5, 2024
Updates #7314.

Squashed commit of the following:

commit be21493
Author: Eugene Burkov <[email protected]>
Date:   Tue Nov 5 18:42:25 2024 +0300

    updater: upd doc

commit bdb9df9
Author: Eugene Burkov <[email protected]>
Date:   Tue Nov 5 18:41:26 2024 +0300

    all: rename const

commit 7fbabeb
Author: Eugene Burkov <[email protected]>
Date:   Tue Nov 5 18:34:37 2024 +0300

    all: add binary const

commit c9f1a9f
Author: Eugene Burkov <[email protected]>
Date:   Tue Nov 5 18:20:44 2024 +0300

    updater: fix binary perm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants