Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread watcher thumbnails getting copied #1348

Open
ghost opened this issue Aug 26, 2021 · 5 comments
Open

Thread watcher thumbnails getting copied #1348

ghost opened this issue Aug 26, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Aug 26, 2021

A thumbnail from one thread can apply to others added later
Example:
Screenshot_20210826-004826.jpg
Tested on v4.13.6-c832bc44 on a Samsung Note 10 Plus

@Astridchan
Copy link

Astridchan commented Aug 26, 2021

Also happening in catalog
IMG_20210826_131000

@Adamantcheese Adamantcheese added the bug Something isn't working label Sep 1, 2021
@ghost
Copy link
Author

ghost commented Sep 29, 2021

Also happens in threads
Screenshot_20210928-200628.jpg

@debagos
Copy link

debagos commented Oct 2, 2021

I can confirm this bug.
Furthermore sometimes when images fade in, they keep a slight white overlay. I mean they won't become fully opaque.

@lg188
Copy link

lg188 commented Oct 10, 2021

This only happens to me in catalog and only when scrolling down after a while. So the threads are loaded at refresh, and images when you're scrolling to them. What if a thread gets removed or it everything shifts towards page 10, but the threads don't get the same refresh.
It makes sense to not load all images at once so you can't just make it fully synchronous. I'd say do an extra check if the image fits the thread.

@Adamantcheese Adamantcheese pinned this issue Nov 10, 2021
Adamantcheese added a commit that referenced this issue Sep 12, 2022
I think that main thread runnables were still queued up despite the call being cancelled, so this should hopefully fix it? at least it seems to have from my looking
@Adamantcheese
Copy link
Owner

Workaround: Disable embedding. Seems that my understanding of how to coordinate PostAdapter and async updates from EmbeddingEngine is incorrect and is probably causing the issues of duplicate/incorrect/invisible images. If someone more knowledgeable on this stuff than me could help that would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants