Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Suggested file extension: .msi & .nba #48

Closed
scyilk opened this issue May 20, 2023 · 4 comments
Closed

[Feature] Suggested file extension: .msi & .nba #48

scyilk opened this issue May 20, 2023 · 4 comments
Assignees
@AdamRaichu
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@scyilk
Copy link

scyilk commented May 20, 2023

Suggested file extension

.msi and .nba

Documentation

https://fileinfo.com/extension/msi & https://fileinfo.com/extension/nba
@scyilk scyilk added enhancement New feature or request good first issue Good for newcomers labels May 20, 2023
@AdamRaichu
Copy link
Owner

I see that .nba files are listed as zip format. 👍🏻 However, .msi is listed as "binary" which is not necessarily zip format. Could you confirm for me that msi is in fact zip format?

@AdamRaichu AdamRaichu mentioned this issue May 21, 2023
Open
1 task
@AdamRaichu
Copy link
Owner

So I downloaded the node.js msi installer, renamed it to .zip, and tried to open it with windows file explorer. No dice 😕. It appears to be compressed with 7-zip, which is not currently supported by the extension.

See #49 for future updates.

@scyilk
Copy link
Author

scyilk commented May 22, 2023

Sorry, I only checked with 7-zip. You could still add .nba though.

@AdamRaichu
Copy link
Owner

Sorry, I only checked with 7-zip. You could still add .nba though.

I did in the code, but then forgot to publish it (oops). Doing that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdamRaichu AdamRaichu

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scyilk @AdamRaichu