Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Latest version of TorchRL and TensorDict aren't compatible #52

Closed
MorganCThomas opened this issue Oct 25, 2024 · 6 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@MorganCThomas
Copy link
Collaborator

Error

RuntimeError: tensor shape is incompatible with dest shape, got: tensor.shape=torch.Size([128]), dest=torch.Size([3, 512])

Reproduce

acegen-open/tests/check_scripts/run_reinforce_denovo.sh

Environment

torchrl==0.6.0 (5244a90)
tensordict==0.6.0 (8c65dcb)

Discussion

Seems this is a problem with the TransformedEnv adding LSTM/GRU primers, previously the batch size was automatically added as the leading dimension which doesn't seem to happen with this update.

@MorganCThomas MorganCThomas added the bug Something isn't working label Oct 25, 2024
@albertbou92
Copy link
Collaborator

I am able to reproduce the error

@albertbou92
Copy link
Collaborator

pytorch/rl#2521

@stanleyjs
Copy link

Error occurs in torchrl 0.6.0 and tensordict 0.6.2.

I was able to workaround by rolling back both.

@MorganCThomas
Copy link
Collaborator Author

This hasn't been fixed in tensordict yet @stanleyjs. But it is prompting me to specify a requirement version of torchrl and tensordict for acegen. I'll look into doing this ASAP.

@MorganCThomas
Copy link
Collaborator Author

For now, I've created a requirements.txt file with the versions of torchrl and tensordict acegen has been tested with. #54

@MorganCThomas
Copy link
Collaborator Author

#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants