Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasTarget hasValue #106

Open
beachtom opened this issue Apr 17, 2024 · 9 comments
Open

hasTarget hasValue #106

beachtom opened this issue Apr 17, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request ontology

Comments

@beachtom
Copy link
Contributor

As hasTarget and hasValue can either be data or object properties this causes us issues elsewhere.

My suggestion approach

  1. Rename hasTarget to hasLinkedTarget
  2. Create a new data property called hasTarget - should be a string bool or nuber
  3. Create a new object by property (similar to hasLinkedTarget) called hasLinkedValue

Happy to discuss on naming etc.....

@maximelefrancois86
Copy link
Contributor

In the ontology at least it is clear:

I understand you mean: they are both used sometimes as object properties, sometimes as data properties ?

We could also reuse the typical naming convention as in SSN and BOT:

  • hasSimpleValue vs hasValue
  • hasSimpleTarget vs hasTarget

@beachtom
Copy link
Contributor Author

Yes this makes sense - I am happy with these names

hasSimpleXXX is the data properties?

@maximelefrancois86
Copy link
Contributor

yes

@beachtom
Copy link
Contributor Author

Fab @AmnaKRDB @EdliraK are you OK to make the changes if you agree?

@beachtom
Copy link
Contributor Author

Hi all - having a discussion with Passi and Vladamir at the end of the day will have a new proposal here - will post shortly.

@beachtom
Copy link
Contributor Author

  1. What is currently hasTarget be renamed to hasBSDDTarget
  2. Create a new object property hasNestedTarget the range of which should be a CheckMethod
  3. Can we rename hasComparator to hasOperator
  4. Create a new property called hasTarget - which is a datatype property (string, number, bool)
  5. Create a new property called hasBSDDValue - which is an object property
  6. Create a new property called hasNestedValue which has domain CheckMethod

@EdliraK
Copy link
Contributor

EdliraK commented Apr 22, 2024

Done:
What is currently hasTarget be renamed to hasBSDDTarget
Create a new object property hasNestedTarget the range of which should be a CheckMethod
Create a new property called hasBSDDValue - which is an object property
Create a new property called hasNestedValue which has domain CheckMethod

Pending:
Can we rename hasComparator to hasOperator

  • I see that before we named it hasOperator and then it was renamed hasComparator...would you like to go back to hasComparator?
    #aec3po:hasOperator a owl:FunctionalProperty,

Create a new property called hasTarget - which is a datatype property (string, number, bool)
I created hasTarget as string. Do you need one for each type?

@beachtom
Copy link
Contributor Author

  1. Yes let's rename it back.
  2. Ideally string number and bool properties

@maximelefrancois86
Copy link
Contributor

Watch out, there is:

hasOperator in https://github.com/Accord-Project/aec3po/blob/main/src/check_method.ttl#L177-L182 , also in https://github.com/Accord-Project/aec3po/blob/main/src/vocabularies/check_method_operators.ttl#L176-L182

hasComparator in https://github.com/Accord-Project/aec3po/blob/main/src/vocabularies/check_method_comparators.ttl#L115-L122

We may just want to move the definition of one term from a module to another (and change rdfs:isDefinedBy metadata)

@VladimirAlexiev VladimirAlexiev added enhancement New feature or request ontology labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ontology
Projects
None yet
Development

No branches or pull requests

5 participants