Fixing flaky test #256
Open
Fixing flaky test #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran your test-suite by removing all seed settings (such as
np.random_seed(0)) and found that some tests fail quite often. For instance, the testtest_select_best_model_ranking_randomfailed 3 out of 500 times. Each time the same assertion failed.To fix the test, I modified the assertion to ensure that it does not fail if the seeds are removed (or if the seed/rng implementation is changed in the future). The test does not fail now at all without seeds.
Please let me know if this fix seems reasonable. If yes, I can also look into other tests which failed and try to make them less flaky. I will be happy to incorporate any other changes that you guys may suggest.
Thanks!