Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkillLab integration #2687

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

SkillLab integration #2687

wants to merge 9 commits into from
+864 −3

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Nov 26, 2024 •
edited
Loading

see #2623

To test the prototype / mock, visit the Details View of a Child record use the "Link external profile" button in the form.

TODOs

  • load ESCO skill details (name, description) via API
  • Skills field doesn't update immediately yet after clicking "Update data"
  • implement a bulk import/link workflow
  • make details for matching configurable (Entity Type, fields for search (fullName, email, ...), etc.)

Refactorings:

  • implement a re-usable ErrorDetailsComponent (for LinkExternalProfileDialogComponent as well as ReportingComponent and other places where we need to both display a simple message and give access to technical error details for experts)
  • make the Bulk Actions configurable through a service instead of hard-coding actions into EntityListComponent (--> similar or combined (?) system to the EntityActionsMenuService)

@github-actions GitHub Actions
Copy link

Deployed to https://pr-2687.aam-digital.net/

@sleidig sleidig marked this pull request as draft November 27, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sleidig @tomwwinter