Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make webclient response parsing more fault-tolerant #25

Open
tomwwinter opened this issue Jul 23, 2024 · 0 comments
Open

refactor: make webclient response parsing more fault-tolerant #25

tomwwinter opened this issue Jul 23, 2024 · 0 comments
Labels
Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user

Comments

@tomwwinter
Copy link
Contributor

Currently we try to parse the response from a webClient call directly within the "bodyToMono" block, wich lead to an decoding error when our DTO is not matching the response result. Also we lost here the actually response from the remote service.

Improvement:

Parse all responses as String and try to map them after that with jacksonObjectMapper. If parsing fails now, we are still able to log the actually response.

@tomwwinter tomwwinter added the Type: Improvement Improvement/Extension of existing feature with benefit for the user label Jul 23, 2024
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Jul 23, 2024
@sleidig sleidig added Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user and removed Type: Improvement Improvement/Extension of existing feature with benefit for the user labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user
Projects
Status: Todo (ready for work)
Development

No branches or pull requests

2 participants