From 6f8d6c0fce8086667224818da6385159de78df8b Mon Sep 17 00:00:00 2001 From: eugenetangkj Date: Mon, 10 Apr 2023 11:31:44 +0800 Subject: [PATCH 1/4] Set version number in MainApp --- src/main/java/seedu/internship/MainApp.java | 2 +- src/test/java/seedu/internship/MainAppTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/seedu/internship/MainApp.java b/src/main/java/seedu/internship/MainApp.java index c3736d074e7..5887949852d 100644 --- a/src/main/java/seedu/internship/MainApp.java +++ b/src/main/java/seedu/internship/MainApp.java @@ -36,7 +36,7 @@ */ public class MainApp extends Application { - public static final Version VERSION = new Version(1, 3, 3, true); + public static final Version VERSION = new Version(1, 4, 1, true); private static final Logger logger = LogsCenter.getLogger(MainApp.class); diff --git a/src/test/java/seedu/internship/MainAppTest.java b/src/test/java/seedu/internship/MainAppTest.java index 6c693b93b51..83d2c2fdb02 100644 --- a/src/test/java/seedu/internship/MainAppTest.java +++ b/src/test/java/seedu/internship/MainAppTest.java @@ -9,7 +9,7 @@ public class MainAppTest { @Test public void getVersionNumber_correct() { - assertEquals(MainApp.VERSION, new Version(1, 3, 3, true)); + assertEquals(MainApp.VERSION, new Version(1, 4, 1, true)); } } From c16f15a16bceccf51cf54379c43435672a0ab037 Mon Sep 17 00:00:00 2001 From: eugenetangkj Date: Mon, 10 Apr 2023 18:57:15 +0800 Subject: [PATCH 2/4] Fix typo in test cases --- docs/DeveloperGuide.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index 1f96cf00936..e91a915e5bc 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -1350,7 +1350,7 @@ Assumptions: The sample data provided by InternBuddy is used, where there is a t **Expected**: An error message is displayed in the Result Display. This is because `Interviewing` is not a valid value for the `STATUS` field. -6. `find n/Google n/Meta s/New s/Assessment` +6. `find n/Google n/Samsung s/Applied s/Assessment` **Expected**: Only the internship entry with company name `Google` and status `Assessment` is filtered out. This is because all other internship entries do not have a matching value with both @@ -1439,9 +1439,9 @@ Assumptions: The sample data provided by InternBuddy is used, where there is a t **Expected**: An error message is displayed in the Result Display. This is because `Interviewing` is not a valid value for the `STATUS` field. -6. `delete-field n/Google n/Meta s/Assessment s/Applied` +6. `delete-field n/Google n/Samsung s/Assessment s/Applied` - **Expected**: Only the internship with company name `Google` and status `Applied` is deleted, + **Expected**: Only the internship with company name `Google` and status `Assessment` is deleted, because all the other internships do not have a matching field for both `CompanyName` and `Status`. 7. `delete-field s/Assessment s/Interview t/Android` From c2d48573ec48c33c3eaa8fbd4e128a50f8898fd0 Mon Sep 17 00:00:00 2001 From: eugenetangkj Date: Mon, 10 Apr 2023 19:08:50 +0800 Subject: [PATCH 3/4] Update documents --- docs/UserGuide.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index f38b83eef92..8f00286aa2d 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -733,7 +733,6 @@ Example:
[//]: # (@@author DerrickSaltFish - reused with modifications) -[//]: # (Adapted from https://ay2223s1-cs2103t-w17-4.github.io/tp/UserGuide.html#navigating-the-user-guide) ### Saving your Internship Data Your internship data for InternBuddy are saved automatically after any command that changes the data. The data are saved From 14436c64804836d2467e8d2d4e49321fd75b4939 Mon Sep 17 00:00:00 2001 From: eugenetangkj Date: Mon, 10 Apr 2023 19:28:20 +0800 Subject: [PATCH 4/4] Remove modifications --- docs/UserGuide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 8f00286aa2d..004636c53ee 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -732,7 +732,7 @@ Example:
-[//]: # (@@author DerrickSaltFish - reused with modifications) +[//]: # (@@author DerrickSaltFish) ### Saving your Internship Data Your internship data for InternBuddy are saved automatically after any command that changes the data. The data are saved