Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D] duplicate endpoints with the same URL and method are added if tag is different #472

Closed
nus-pe-bot opened this issue Apr 3, 2021 · 1 comment · Fixed by #577
Closed
Assignees
Labels
invalid Invalid bug reports priority.Medium Nice to have type.Task Something that needs to be done, but not a story, bug, or an epic.
Milestone

Comments

@nus-pe-bot
Copy link

image.png

As the defining characteristics of endpoints should be their URL and method type, an user might expected endpoints with the same url and method are considered to be duplicates, and thus should not be able to be added in the saved endpoints twice. The definition of duplicate endpoints for imPoster seems to be only if all of the fields are identical. Perhaps could change the criteria to URL and Method?


Labels: severity.Low type.FeatureFlaw
original: jingxueguo/ped#3

@tjtanjin
Copy link
Member

tjtanjin commented Apr 4, 2021

Just a note:

This was discussed within the team before and the consensus reached is that endpoint with the same URL, method type, header and data might be used for different purposes (identified with a tag). Let's say the tag represents a project that the endpoint belongs to. In this use case, differentiating endpoints with tags would be relevant to keep endpoints organised for different projects.

@tjtanjin tjtanjin self-assigned this Apr 6, 2021
@tjtanjin tjtanjin added invalid Invalid bug reports priority.Medium Nice to have type.Task Something that needs to be done, but not a story, bug, or an epic. labels Apr 6, 2021
@tjtanjin tjtanjin added this to the v1.4b milestone Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Invalid bug reports priority.Medium Nice to have type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants