Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names with hyphens and apostrophes are skipped #26

Open
benjamin051000 opened this issue Feb 5, 2023 · 5 comments
Open

Names with hyphens and apostrophes are skipped #26

benjamin051000 opened this issue Feb 5, 2023 · 5 comments
Labels
bug Something isn't working low priority

Comments

@benjamin051000
Copy link
Member

This was definitely an issue before, but seems to have popped up again.

Names with the pattern (real names redacted) <Firstname> <Lastnameone>-<Lastnametwo>

Are not extracting properly. They should have unzipped directories created for them in Submissions/ and their names should be shown in the "Students to grade" list.

@benjamin051000
Copy link
Member Author

A solution has been identified:

Replacing the "-" in the last name with a space " " resolves the issue. This worked when utilizing the --section flag. The names were edited in the all_students.csv file.

Note: In the CSV, the entry is <Lastnameone>-<Lastnametwo>, <Firstname>. Replacing the - with a space resolved the problem.

@benjamin051000
Copy link
Member Author

FYI, when viewing the .csv raw, the first entry allows for a comma because it is wrapped in quotes. This is how it looks:

"<Lastnameone>-<Lastnametwo>, <Firstname>", ufid, blah, blah, blah

the comma within the first column is ignored since the quotes "escape" it.

@jalvarez1492
Copy link
Collaborator

This issue also happens with apostrophe last names, I will try just editing the all_students.csv file to replace it with a space.

@benjamin051000
Copy link
Member Author

It may be worth utilizing a third-party package for this, such as https://github.com/derek73/python-nameparser

Before we do that, however, I'd want to test it and see how well it performs, especially for people with more than two names, names with - and ', etc. I could test on previous years' submission datasets... I just wish canvas didn't do the stupid name mangling!

@benjamin051000 benjamin051000 changed the title Hyphenated last names are not being picked up Names with hyphens and apostrophes are skipped Feb 9, 2023
@benjamin051000
Copy link
Member Author

Thanks @jalvarez1492 , I think the above package may be a good potential solution to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority
Projects
None yet
Development

No branches or pull requests

2 participants