From e5d8b67d7940aa63be42bc3cefdae9c79ac6571c Mon Sep 17 00:00:00 2001 From: Cristian Recoseanu Date: Tue, 19 Nov 2024 10:02:28 +0000 Subject: [PATCH 1/4] Revise conformance language around direct implementation or derived variant --- docs/Overview.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Overview.md b/docs/Overview.md index 43ae503..90ed2fb 100644 --- a/docs/Overview.md +++ b/docs/Overview.md @@ -55,7 +55,7 @@ The technical model describing the monitoring requirements for a sender is [NcSe This model inherits from the baseline status monitoring model [NcStatusMonitor](https://specs.amwa.tv/nmos-control-feature-sets/branches/publish-status-reporting/monitoring/#ncstatusmonitor). -For implementations to be in conformance with the BCP they MUST implement [NcSenderMonitor](https://specs.amwa.tv/nmos-control-feature-sets/branches/publish-status-reporting/monitoring/#ncsendermonitor) directly or as a [vendor specific variant derived from NcSenderMonitor](https://specs.amwa.tv/ms-05-02/latest/docs/Introduction.html) which can add more statuses, properties and methods. +Sender monitors MUST implement [NcSenderMonitor](https://specs.amwa.tv/nmos-control-feature-sets/branches/publish-status-reporting/monitoring/#ncsendermonitor) directly or derive a [vendor specific variant derived from NcSenderMonitor](https://specs.amwa.tv/ms-05-02/latest/docs/Introduction.html) which MAY add more statuses, properties and methods but MUST still comply with the requirements set out in this specification. | ![Sender monitoring model](images/sender-model-minimal.png) | |:--:| From 1d96a7a81a2adaf17b0ba13fac54ed2edd8d47e3 Mon Sep 17 00:00:00 2001 From: Cristian Recoseanu Date: Tue, 19 Nov 2024 10:02:47 +0000 Subject: [PATCH 2/4] Add Touchpoints and IS-04 senders section --- docs/Overview.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/docs/Overview.md b/docs/Overview.md index 90ed2fb..fd1c32b 100644 --- a/docs/Overview.md +++ b/docs/Overview.md @@ -255,3 +255,25 @@ When a sender is being deactivated it MUST cleanly interrupt its transmission by * overallStatus * transmissionStatus * essenceStatus + +### Touchpoints and IS-04 senders + +Sender monitors make use of the [Touchpoints](https://specs.amwa.tv/ms-05-02/latest/docs/NcObject.html#touchpoints) mechanism inherited from [NcObject](https://specs.amwa.tv/ms-05-02/latest/docs/NcObject.html) to attach to the correct sender identity. + +The `touchpoints` property of any [NcSenderMonitor](https://specs.amwa.tv/nmos-control-feature-sets/branches/publish-status-reporting/monitoring/#ncsendermonitor) MUST have one or more touchpoints of which one and only one entry MUST be of type [NcTouchpointNmos](https://specs.amwa.tv/ms-05-02/latest/docs/Framework.html#nctouchpointnmos) where the `resourceType` field MUST be set to "sender" and the `id` field MUST be set to the associated IS-04 sender UUID. + +Sender monitors MUST maintain a 1 to 1 relationship between its role and the sender resource it monitors (expressed via the `touchpoints` property) for the lifetime of the IS-04 sender resource. + +Touchpoints example: + +```json +[ + { + "contextNamespace": "x-nmos", + "resource": { + "resourceType": "sender", + "id": "9bfe1101-5513-45fa-ae3b-7e668e317bd5" + } + } +] +``` From 8addb724f793ac4169f4db12fd36024e3db0b035 Mon Sep 17 00:00:00 2001 From: Cristian Recoseanu Date: Tue, 19 Nov 2024 10:03:02 +0000 Subject: [PATCH 3/4] Add NcWorker inheritance section --- docs/Overview.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/Overview.md b/docs/Overview.md index fd1c32b..1a3ef83 100644 --- a/docs/Overview.md +++ b/docs/Overview.md @@ -277,3 +277,13 @@ Touchpoints example: } ] ``` + +### NcWorker inheritance + +[NcStatusMonitor](https://specs.amwa.tv/nmos-control-feature-sets/branches/publish-status-reporting/monitoring/#ncstatusmonitor) inherits from the [NcWorker](https://specs.amwa.tv/ms-05-02/latest/docs/Framework.html#ncworker) model. + +Since [NcSenderMonitor](https://specs.amwa.tv/nmos-control-feature-sets/branches/publish-status-reporting/monitoring/#ncsendermonitor) inherits from the [NcStatusMonitor](https://specs.amwa.tv/nmos-control-feature-sets/branches/publish-status-reporting/monitoring/#ncstatusmonitor) model then it also indirectly inherits from the [NcWorker](https://specs.amwa.tv/ms-05-02/latest/docs/Framework.html#ncworker) model. + +Sender monitors MUST always have the `enabled` property set to `true`. + +Sender monitors MUST NOT allow changes to the `enabled` property and instead MUST return `InvalidRequest` to Set method invocations for this property. From 29b17988f8c0519ab002abaca5d2d8d254f06361 Mon Sep 17 00:00:00 2001 From: Cristian Recoseanu Date: Thu, 21 Nov 2024 14:10:21 +0000 Subject: [PATCH 4/4] Remove second "derived" for clarity --- docs/Overview.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Overview.md b/docs/Overview.md index 1a3ef83..78c5535 100644 --- a/docs/Overview.md +++ b/docs/Overview.md @@ -55,7 +55,7 @@ The technical model describing the monitoring requirements for a sender is [NcSe This model inherits from the baseline status monitoring model [NcStatusMonitor](https://specs.amwa.tv/nmos-control-feature-sets/branches/publish-status-reporting/monitoring/#ncstatusmonitor). -Sender monitors MUST implement [NcSenderMonitor](https://specs.amwa.tv/nmos-control-feature-sets/branches/publish-status-reporting/monitoring/#ncsendermonitor) directly or derive a [vendor specific variant derived from NcSenderMonitor](https://specs.amwa.tv/ms-05-02/latest/docs/Introduction.html) which MAY add more statuses, properties and methods but MUST still comply with the requirements set out in this specification. +Sender monitors MUST implement [NcSenderMonitor](https://specs.amwa.tv/nmos-control-feature-sets/branches/publish-status-reporting/monitoring/#ncsendermonitor) directly or derive a [vendor specific variant from NcSenderMonitor](https://specs.amwa.tv/ms-05-02/latest/docs/Introduction.html) which MAY add more statuses, properties and methods but MUST still comply with the requirements set out in this specification. | ![Sender monitoring model](images/sender-model-minimal.png) | |:--:|