Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE file. #36

Closed
afs opened this issue May 20, 2022 · 3 comments
Closed

Add LICENSE file. #36

afs opened this issue May 20, 2022 · 3 comments
Assignees

Comments

@afs
Copy link

afs commented May 20, 2022

A top level LICENSE means github will pick it up.

@saleem-muhammad
Copy link
Contributor

Sorry I did not get it. Can you please further explain ?

@afs
Copy link
Author

afs commented May 21, 2022

Hi @saleem-muhammad

(This is related to a conversation with @Aklakan and @LorenzBuehmann .)

The convention in open source is to put a file named LICENSE in the top level directory with the license in it. It helps people find the license.

And it becoming for tools as well. github scans repos, determines the license from a set it knows about, and adds the information to the "about" panel and also puts it in the repositories listing for the organisation.

See for example: https://github.com/AKSW/gson-utils/LICENSE (@Aklakan).

The other convention is NOTICE, which is for the required legal statements that downstream. The Apache License does not have such a requirement. Apache Software Foundation put the copyright statement in their NOTICE file.

e.g.
https://github.com/apache/commons-lang/blob/master/NOTICE.txt

Happy to help - but not PR in this case. The LICENSE ought to be added by an owner!

@Aklakan Aklakan self-assigned this May 21, 2022
@Aklakan
Copy link
Member

Aklakan commented May 21, 2022

@afs Thanks for pointing out the missing license - Its now the usual Apache V2.

@Aklakan Aklakan closed this as completed May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants