-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 contract in some orders on a circuit with ring struction may get incorrect multiplication counts. #99
Labels
Comments
Yonv1943
changed the title
🐛 Shrinking in a certain order on a circuit with a loop can result in a incorrect multiplication count.
🐛 contract in some orders on a circuit with ring struction may get incorrect multiplication counts.
Apr 8, 2023
The following code fix this bug in Vanilla (single) mode. The First, choose a reasonable data type. It is safer that use float32 instead of int/long for
Vectorized version
|
YangletLiu
added
help wanted
Extra attention is needed
discussion
code understanding
labels
Apr 8, 2023
修改后,我还使用换底公式
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
收缩 sycamore 以及 tensor grid ,tensor ring 这种有环状结构的电路,会有bug,导致乘法次数计算错误
(刚好我们测试的 tensor train,tensor tree 没有环状结构)
需要有环状结构,且按某个顺序收缩张量节点,才会触发
下面的代码,在一个小规模的 sycamore 电路 NodesSycamoreN12M14 上得到,然后逐行检查发现了这个bug
先粗略记录一下。
这是print代码
这是print内容。可以看到,对已经收缩的节点竟然进行了不可能的收缩,并且产生了多余的乘法次数。
The text was updated successfully, but these errors were encountered: