Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show docs for packages not installed/runnable #37

Open
jan-dolejsi opened this issue Jun 1, 2022 · 3 comments
Open

Don't show docs for packages not installed/runnable #37

jan-dolejsi opened this issue Jun 1, 2022 · 3 comments

Comments

@jan-dolejsi
Copy link

The kstar solver is not included in the package list? One can access it this way:
http://45.113.232.43:5001/docs/kstar
... but it does not look like it is in the http://45.113.232.43:5001/package. Because it does not have the package_name field populated?

@haz
Copy link
Contributor

haz commented Jun 1, 2022

Aha! This is a bug on the docs side, and not the package listing. kstar is not officially deployed. What's "official" is defined by...

https://github.com/AI-Planning/planning-as-a-service/blob/main/server/Dockerfile

You can access any of the manifests in the planutils library through the docs. E.g., even tarski library (which definitely does not have an endpoint).

Changing the title of the issues to reflect its true nature.

@haz haz changed the title kstar not available in the package list? Don't show docs for packages not installed/runnable Jun 1, 2022
@jan-dolejsi
Copy link
Author

Oh, I see. If the /docs interface is capable of showing files on the disk (rather than just registered and white-listed locations as per the Dockerfile), it may be exploited by a hack.

@haz
Copy link
Contributor

haz commented Jun 3, 2022

Ya, it's not wide open on the file system, but rather a bug with which packages it pulls from. It should be checked if it's installed before returning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants