Replies: 1 comment
-
Ya, I think it's safe to keep them separate for now. So return the |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Right now,
Trace.tokenize()
uses the givenToken
(Observation
class) to get observation tokens for each step, and appends them to a list attribute.With
TraceList.tokenize()
we are going to return anObservationList
object, not store anything on an internal attribute.So should
Trace.tokenize()
just return the list of observations instead of storing them? Or is there a good reason to store the list of observations on aTrace
?Beta Was this translation helpful? Give feedback.
All reactions