-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full support for Python3.x. #3
Comments
So there are a few things to note here...
Thanks! |
On another note, I've already made a container which runs the solver. I can also add it so you can use it as a baseline for the next iteration. If that is the case, I could open another issue where we could discuss this topic so that we don't end up mixing topics in this one 😆. |
Great! Well if you wanted to contribute (which would be awesome), what I would advocate is that you check out the existing Docker setup that we'll build off of... ...and the issue created for the solver environment... ...and the discussion that captures how it's going to look... There's also a WIP PR for it, but that's mainly empty for now while I pick away at the new manifest for plackages. |
Closing for now (thanks for the PR!), but feel free to join the conversation on the Docker extension either in the issue listed above or the slack org. |
No problem! As far as I have understood, the goal is to create an environment in which multiple planners can be run and run the |
The goal is multi-faceted. But what you include is certainly in there, yep. And the cloud-solver project will wrap many planners / planner services (like generating domains/problems). There will be a new meta-data defined for the solvers, which is reflected in the cloud-solver API automatically, and it will be hosted somewhere with a bit beefier resources (so more than one simultaneous solve can take place). |
I am trying to create a Docker container where the solver could be run. This container uses the latest version of both Python and NodeJS, which are Python 3.8 and NodeJS 12 iirc.
As you already know, the
preprocess_solution.py
script has to be run after the planner has completed its execution. However, the script is executed using thepython
binary, which is a symbolic link to the Python interpreter. This symbolic link may point topython2
orpython3
, depending on whether Python2.x is installed or not in the OS by default. This means that new OS which don't havepython2
installed would have an issue when trying to run the script, and consequently, there would be a problem while trying to run the solver. This happens because of the following reasons:map
function returns map object instead of a list in Python3.These issues can be solved while keeping the compatibility between both versions of the language. As a matter of fact, I have already made some modifications to the fork that I have of this repo. I can create a PR so you can review the changes, and then you could decide if you want to integrate them to the project.
The text was updated successfully, but these errors were encountered: