-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return all of the ground actions possible instead of failing for just one #2
Comments
Here is the link for the domain and problem file. Got the same result when use online editor: http://editor.planning.domains/#edit_session=jVYVlhdoeRirKvL |
Fascinating... @nirlipo would the planner be adding a final step to reach the goal given that it's a non-standard one (negations and disjunctions). @guanghuhappysf128 Keep in mind that you should only share read-only links from the editor (otherwise anyone with the link can start making edits!) |
Btw, the error status there is due to us not being able to extract the grounded action schema for display -- not an error in trying to find a plan. This is why a plan shows, but in the online editor you don't have the full action descriptions for each step. |
This is a technique used in preprocessing by FF-parser to handle disjunctive goal formulas, adding For this domain with goal formula
we get:
and the goal of the problem is set to |
So it was the disjunction in the end. The data-structures ok with multiple actions using the same name? Wild... |
Better to be safe :) We map each action to a unique ID, just in case the parser generates groundings that PDDL wouldn't allow, like naming conventions. |
This example in LAPKT is useful, as it gets pddl files and prints the output of FF-parser. |
Beauty. So @guanghuhappysf128 , I hope this makes it clear where/why things were breaking for you. I'm going to rename the issue title to address the fact that the solution parser could be a little more robust in what it extracts (so it should show the full actions for those it manages to extract, rather than failing outright). Thanks for reporting! |
When I use solver API, the following case happens. I didn't have any action named
reach-goal
. Here is the return json:Could you please help me out on figure out how could this happened?
The text was updated successfully, but these errors were encountered: