Sweep: Create LanceDB index after table is created in import #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback: 👎
Description
This pull request introduces enhancements to the LanceDB import process by automatically creating an index on the
id
column after a table is created. This feature aims to improve query performance on the imported tables by leveraging the indexing capabilities of LanceDB.Summary
create_index
from thelancedb
module to support index creation.ID_COLUMN
set to"id"
, which specifies the default column to index.id
column in the parquet file schema during the import process. If theid
column is found, an index is created on this column for the newly created table.id
column is not found in the parquet schema, in which case the index creation is skipped for the table.Modified Files
src/vdf_io/import_vdf/lancedb_import.py
: Main changes include the addition of index creation logic after table creation, import statement forcreate_index
, and theID_COLUMN
class variable definition.This enhancement ensures that every table imported into LanceDB has an index on its
id
column (when present), significantly improving the efficiency of operations that rely on this column.Fixes #80.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can:
This is an automated message generated by Sweep AI.