Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use srdf tag group state to let user says the default joint pos #65

Open
torydebra opened this issue Jul 29, 2020 · 4 comments
Open

Use srdf tag group state to let user says the default joint pos #65

torydebra opened this issue Jul 29, 2020 · 4 comments
Assignees
Labels
future possible enhancement New features that could be taken into consideration in the future

Comments

@torydebra
Copy link
Member

No description provided.

@torydebra torydebra added the enhancement New feature or request label Jul 29, 2020
@torydebra torydebra self-assigned this Jul 29, 2020
@torydebra
Copy link
Member Author

Some problems for this, I checkout at new branch https://github.com/ADVRHumanoids/ROSEndEffector/tree/srdfInitialPos

@torydebra
Copy link
Member Author

torydebra commented Aug 5, 2020

ROSEE is ready to use with this new feature, I have also tested it a bit.

Problem is that the joint_state_publisher does not read srdf, thus it is not aware of possible initial joint position different from 0.
Possible solutions are:

  • Use a yaml file where the zeros of the joint are written. This is the standard way documented for joint state pub. The problem here is to have this additional duplicated file, and we need it for each end-effector, even if the joint position are all 0 (because we have to indicate it in the launch file, and error is thrown if the file does not exists).
  • Modify joint_state_pub such that it reads srdf
  • Send a init command from ROSEE after parsing the robot with its initial joints positions. Not really coherent though, ROSEE should always pass through the filter and the hal to send robot commands.
  • Send a init command from a "initialization ros node", then shutdown it and run rosee.

Similar problem happens also when gazebo (and not anymore joint state pub) is used, but it should be easier to set initial pos in gazebo

UPDATE: also take care that setToDefault position passive joint rosee method should take this srdf updates, if implemented

@torydebra
Copy link
Member Author

BTW, I think this feature is not so important, so we can delay its integration

@lia2790
Copy link

lia2790 commented Aug 5, 2020

I think y can leave it...

@torydebra torydebra added future possible enhancement New features that could be taken into consideration in the future and removed enhancement New feature or request labels Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future possible enhancement New features that could be taken into consideration in the future
Projects
None yet
Development

No branches or pull requests

2 participants