Build against Java 21 #2929
Open
Build against Java 21 #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
reviewed
Oct 15, 2024
sstone
changed the title
sstone
changed the title
sstone
force-pushed
the
prepare-jdk21
branch
from
a66947c to
823c60c
Compare
Previous version was not compatible with JDK21, see kamon-io/kanela#150.
This will make it easier to control which version of maven is used to build eclair, which in turns makes deterministic builds easier, as well as using recent compiler options (to target newer JDKs for example). For example, even recent versions of Github runner images use an old verion of maven and there is no easy way to upgrade.
We now use multiarch (amd64/arm64) base images.
Eclair now targets Java 21 and will require a compatible Java Runtime Environment. It will no longer work on JRE 11 and JRE 17.
sstone
force-pushed
the
prepare-jdk21
branch
from
58cd6d7 to
dc82525
Compare
|
Our test and production images have been updated and this PR is now safe to merge. |
t-bast
reviewed
Dec 12, 2024
sstone
force-pushed
the
prepare-jdk21
branch
from
07aaf76 to
5dc600d
Compare
t-bast
reviewed
Dec 12, 2024
t-bast
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are small, non-functional changes that are needed to target Java 21. The only real issue was the kanela agent, the version we used is not compatible with JDK21.
Eclair will require a Java runtime that is compatible with Java 21 and will no longer run on JRE 11 or JRE 17: DO NOT MERGE this PR until production environments have been updated with a Java 21 compatible JRE !!