Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ExtendedBlockState before rendering in block overlay fix #548

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Get ExtendedBlockState before rendering in block overlay fix #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dbada8
Support ExtendedBlockStates in block overlay fix
jchung01 Aug 28, 2024
20c4cbb
Remove now unnecessary blacklist entry
jchung01 Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/mod/acgaming/universaltweaks/bugfixes/blocks/blockoverlay/UTBlockOverlay.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ public static void renderNearbyBlocks(float partialTicks)
bufferBuilder.setTranslation(-x, -(y - player.getEyeHeight()), -z);
}
IBlockState state1 = state.getActualState(world, pos);
// Call extendedBlockState if it has one: see BlockRendererDispatcher#renderBlock()
state1 = state.getBlock().getExtendedState(state1, world, pos);
mc.getBlockRendererDispatcher().getBlockModelRenderer().renderModel(world, mc.getBlockRendererDispatcher().getModelForState(state1), state1, pos, bufferBuilder, false);
});

Expand Down
5 changes: 1 addition & 4 deletions src/main/java/mod/acgaming/universaltweaks/config/UTConfigBugfixes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,7 @@ public static class BlockOverlayCategory
"Excludes blocks from the block overlay bugfix",
"Syntax: modid:block"
})
public String[] utBlockOverlayBlacklist = new String[]
{
"appliedenergistics2:drive"
};
public String[] utBlockOverlayBlacklist = new String[] {};

@Config.Name("[3] Whitelist")
@Config.Comment
Expand Down