Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Radar Exception #492

Merged
merged 3 commits into from
Jun 16, 2024
Merged

Catch Radar Exception #492

merged 3 commits into from
Jun 16, 2024

Conversation

WaitingIdly
Copy link
Contributor

changes in this PR:

  • catches AbstractMethodErrors in the Extra Utilities Radar feature (find in nearby inventories) to allow Radar to still find items in nearby inventories when one of the nearby inventories breaks. (default: true)

this frequently happens when near BiblioCraft blocks, such as in this log:

Error executing task
java.util.concurrent.ExecutionException: java.lang.AbstractMethodError: Method jds/bibliocraft/tileentities/TileEntityArmorStand.getStackInSlot(I)Lnet/minecraft/item/ItemStack; is abstract
        at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_411]
        at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_411]
        at net.minecraft.util.Util.runTask(SourceFile:531) [h.class:?]
        at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:723) [MinecraftServer.class:?]
        at net.minecraft.server.dedicated.DedicatedServer.updateTimeLightAndEntities(DedicatedServer.java:397) [nz.class:?]
        at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:668) [MinecraftServer.class:?]
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_411]
Caused by: java.lang.AbstractMethodError: Method jds/bibliocraft/tileentities/TileEntityArmorStand.getStackInSlot(I)Lnet/minecraft/item/ItemStack; is abstract
        at jds.bibliocraft.tileentities.TileEntityArmorStand.getStackInSlot(TileEntityArmorStand.java) ~[TileEntityArmorStand.class:2.4.6]
        at com.rwtema.extrautils2.crafting.Radar$PacketPing.lambda$doStuffServer$1(Radar.java:185) ~[Radar$PacketPing.class:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_411]
        at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_411]
        at net.minecraft.util.Util.runTask(SourceFile:529) ~[h.class:?]
        ... 5 more

Copy link

what-the-diff bot commented Jun 16, 2024

PR Summary

  • Improved Stability of Radar Feature
    The specific changes in this pull request address an earlier issue with the Radar feature in the Extra Utilities 2 software. Previously, the Radar feature was breaking down or becoming less effective when utilized near certain kinds of inventories. This fix ensures that the Radar feature maintains optimal performance, regardless of the proximity to any inventory, increasing its reliability and efficiency.

@ACGaming ACGaming merged commit 9af4769 into ACGaming:main Jun 16, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the radar-erroring branch June 17, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants