Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model architecture with --model="ScaleShiftMACE" #633

Open
wcwitt opened this issue Oct 10, 2024 · 1 comment
Open

Model architecture with --model="ScaleShiftMACE" #633

wcwitt opened this issue Oct 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@wcwitt
Copy link
Collaborator

wcwitt commented Oct 10, 2024

Assuming most other defaults are used, models trained with --model="ScaleShiftMACE" appear to be different in at least one important, nonobvious way from models trained with --model="MACE".

Specifically, --model="ScaleShiftMACE" yields an architecture where both layer interactions are RealAgnosticResidualInteractionBlock, whereas the default MACE uses RealAgnosticInteractionBlock in the first layer and RealAgnosticResidualInteractionBlock in the second.

Perhaps the most significant consequence is that the linear weights applied after the first pooling are element-dependent for the default architecture but not element-dependent by default for --model="ScaleShiftMACE.

Hopefully I have understood everything correctly - @ilyes319 can confirm. Perhaps not technically a bug, but probably needs documentation. My impression is that some users are still in the habit of setting --model=ScaleShiftMACE, and they may not be getting what they expect.

@birdyLinch
Copy link
Collaborator

birdyLinch commented Oct 20, 2024

Thanks for bringing this up! Upon checking the main branch: here for --model="MACE" the first interaction block would be fixed as RealAgnosticInteractionBlock while here it would be reading the argument --interaction_first from the config and was settled with RealAgnosticResidualInteractionBlock as default here in argparser. Shall we change the default to RealAgnosticInteractionBlock, or is it required for backward compatibility @ilyes319 ?

@ilyes319 ilyes319 added the enhancement New feature or request label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants