Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Modern industrialization metals for bulk compression. #154

Closed
xtended2l opened this issue Dec 12, 2024 · 6 comments
Closed

Support for Modern industrialization metals for bulk compression. #154

xtended2l opened this issue Dec 12, 2024 · 6 comments

Comments

@xtended2l
Copy link

Please add support for MI metals i.e. antimony, stainless steel, titanium, etc.

@62832
Copy link
Owner

62832 commented Dec 13, 2024

This depends entirely on the recipes used by Modern Industrialisation, which I'm not in control of. You can also manually add all these metals yourself to the #megacells:compression_overrides tag via a datapack if there's something unusual about the recipes, assuming no other problems arise when doing so.

@62832 62832 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2024
@xtended2l
Copy link
Author

Are you sure? These are simple metals, which use default "9 nugget -> ingot", "9 Ingots -> Block" recipes. Drawers convert all these metals just fine.
Moreover bulk cell converts some of them - Coke, Lignite coal and Tungsten converts just great, that's why it is weird.

@62832
Copy link
Owner

62832 commented Dec 14, 2024

Are there any overrides already specified by things like your drawer mod? Without any information on which drawer mod you're using, that tells me nothing.

Besides, I had word earlier in the day that the recipes for metals in MI are indeed non-standard and as such won't be automatically picked up by bulk compression due to the criteria it's designed to look for in recipes. It seems that MI's metal storage recipes use the common resource tag for 8 ingredient keys but the MI-specific metal resource in the centre, which throws the system off and makes it think this recipe is not a standard one it's looking for.

@xtended2l
Copy link
Author

I play ATM10 modpack. And there is Functional Storage mod, I mean compacting drawers from this mod.

@62832 62832 reopened this Dec 25, 2024
@62832
Copy link
Owner

62832 commented Dec 25, 2024

Turns out I have been able to make a good few adjustments to the compression system to be able to catch some more odd cases, including the recipes for Modern Industrialization. This should make its way into the next release build.

@xtended2l
Copy link
Author

Wow, great! :) Thank you and happy holidays!

@62832 62832 closed this as completed in 98e2721 Dec 27, 2024
62832 added a commit that referenced this issue Dec 27, 2024
- Allow for compression/decompression recipes with amounts other than 4 and 9 (e.g. certain mods' "Tiny Coal/Charcoal")
- Add a new "compression blacklist" tag with which to prevent certain items from ever appearing in a compression chain, override or not
- Refine compression recipe logic in order to better catch other odd cases such as mods with atypical ingot/block recipes for their own metals (Closes #154, but does assume the presence of some unification mod such as AlmostUnified)
- Add better, more detailed logging for compression including debug logs for every individually generated chain and override
- Add some more default overrides such as string, snow and honeycomb
62832 added a commit that referenced this issue Dec 28, 2024
- Allow for compression/decompression recipes with amounts other than 4 and 9 (e.g. certain mods' "Tiny Coal/Charcoal")
- Add a new "compression blacklist" tag with which to prevent certain items from ever appearing in a compression chain, override or not
- Refine compression recipe logic in order to better catch other odd cases such as mods with atypical ingot/block recipes for their own metals (Closes #154, but does assume the presence of some unification mod such as AlmostUnified)
- Add better, more detailed logging for compression including debug logs for every individually generated chain and override
- Add some more default overrides such as string, snow and honeycomb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants