Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with maps where it doesn't show pins when switching between facility list and facility #84

Open
jonminter opened this issue Dec 23, 2015 · 5 comments · Fixed by #89
Open

Fix issue with maps where it doesn't show pins when switching between facility list and facility #84

jonminter opened this issue Dec 23, 2015 · 5 comments · Fixed by #89
Labels
bug

Comments

@jonminter
Copy link
Contributor

No description provided.

@jonminter jonminter added the bug label Dec 23, 2015
jonminter pushed a commit that referenced this issue Dec 23, 2015
Fixing issue where google map would not display if you went back to f…
fa39331 
…acility list after viewing individual facility closes #84
@jonminter jonminter mentioned this issue Dec 23, 2015
Merged
@jonminter jonminter reopened this Dec 24, 2015
@jonminter
Copy link
Contributor Author

Was working locally but when deployed still see the issue

@patricknowlan
Copy link
Contributor

I think i fixed this issue by adding an ng-if to the map that checks that the data has been loaded before rendering the map. In pull request #114. This might also be a duplicate of #108 which I closed. I noticed a new issue where the map does not show pins when the state changes based off of navigating screens using the browsers back button.

@patricknowlan
Copy link
Contributor

Should we create a new issue or track it here?

@patricknowlan
Copy link
Contributor

I think this is an issue with the state.

jonminter pushed a commit that referenced this issue Dec 29, 2015
Added ng-if for map to wait until facility data is loaded to try to d…
021e2d2 
…isplay map like in FacilityController, hopefully this will fix the browser back button map issues #84
@jonminter jonminter mentioned this issue Dec 29, 2015
Merged
jonminter pushed a commit that referenced this issue Dec 29, 2015
Updated facility list to reset map on page load #84
1a938a8
jonminter pushed a commit that referenced this issue Dec 29, 2015
Added resize event trigger to facility page #84
75a0c97
jonminter added a commit that referenced this issue Dec 29, 2015
@jonminter
Merge pull request #133 from 540co/facility_map_back_button
ffedf08 
Added resize event trigger to facility page #84
@patricknowlan
Copy link
Contributor

Looks like this is partially fixed. It works for navigating back and forth between the facility list and facility page but the map will not work if you press back until you hit the dashboard page and select a new state. It will require the user to refresh their page once they land on the facility list view in order to view the map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing issue where google map would not display if you went back to f… 540co/epa-rfi
2 participants
@jonminter @patricknowlan