Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knob set still active and navigable after removing all mappings #388

Open
danngreen opened this issue Sep 20, 2024 · 1 comment
Open

Knob set still active and navigable after removing all mappings #388

danngreen opened this issue Sep 20, 2024 · 1 comment

Comments

@danngreen
Copy link
Member

See:
https://forum.4ms.info/t/removing-a-knob-set-and-patch-view/347

@danngreen
Copy link
Member Author

The part to implement for the Issue is removing a knobset after all knob mappings are removed. There might be a slight annoyance if a custom name was set and the user removed all mappings, intending to add different ones, but I think this is an edge case and an easy workaround is to not delete all mappings at once (or add the custom name)

The other issues mentioned: Knob set organizational tools (re-ordering, clear-all, delete) would be a separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant