Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bypass option for modules #375

Open
danngreen opened this issue Sep 10, 2024 · 3 comments
Open

Add bypass option for modules #375

danngreen opened this issue Sep 10, 2024 · 3 comments

Comments

@danngreen
Copy link
Member

Add a button/toggle on the ModuleView page.

Display bypassed module differently on the PatchView (dimmed?)

At first, just mute outputs and ignore inputs. Then, we will extend module info format to include a table of bypass routes. Once that happens we use the table.

@hemmer
Copy link
Collaborator

hemmer commented Sep 10, 2024

ICYMI Rack API encourages developers to set this in their modules, e.g. https://github.com/hemmer/Befaco/blob/v2/src/SpringReverb.cpp#L87

@danngreen
Copy link
Member Author

I started implementing bypass on the 4ms VCV modules by just using configBypass. The bypass routes will be in the 4ms CoreModules info structs, so they'll be available to firmware.
To cross-reference, here's the issue for that:
4ms/4ms-vcv#14

@danngreen
Copy link
Member Author

Ok, just some notes... If someone saves a patch in VCV which has some bypassed modules, then those will need to be bypassed when the patch is loaded. So "bypassed" needs to be added to the patch format, per-module

I have been trying to think of a way around changing the CoreProcessor API since changes here would bump up the Plugin SDK API version. But I haven't figured anything out. At this point the most simple idea I've come up with is to add a new member variable bool bypassed to CoreProcessor, which isn't a big change but we'll want to roll that out at the same time as other API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants