Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more operations to FileIoC #342

Open
LnnrtS opened this issue Aug 23, 2024 · 0 comments
Open

Add more operations to FileIoC #342

LnnrtS opened this issue Aug 23, 2024 · 0 comments
Labels

Comments

@LnnrtS
Copy link
Collaborator

LnnrtS commented Aug 23, 2024

To support more operations on patch files in the wifi module, the filesystem abstraction first needs to implement those.
Required are

  • creating and deleting directories
  • moving files (should cover renaming)

Some more ideas to improve this abstraction layer:

  • const_data and write_buffer are somewhat redundant. Why not just have the const version?
  • foreach_file_with_ext could be replaced with a two step process: One lambda for the selection according to file infos and a second one for the action
  • There could also be a dedicated struct with file information (name, size, timestamp)
  • bool is sometimes used as an success indicator. That could be made explicit by giving it an extra type
  • some methods are not yet required to return anything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants