Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission step can't be hidden for only one submission scope #98

Closed
atarix83 opened this issue Aug 29, 2024 · 0 comments
Closed

Submission step can't be hidden for only one submission scope #98

atarix83 opened this issue Aug 29, 2024 · 0 comments
Assignees
Labels

Comments

@atarix83
Copy link
Collaborator

Describe the bug
By submission form documentation it's possible to configure a step with visibility hidden

immagine

Nevertheless currently it works only if the step is hidden for both scopes, e.g.

<step-definition id="traditionalpageone" mandatory="true">
    <heading>submit.progressbar.describe.stepone</heading>
    <processing-class>org.dspace.app.rest.submit.step.DescribeStep</processing-class>
    <type>submission-form</type>
    <scope visibility="hidden" visibilityOutside="hidden">submission</scope>
</step-definition>

But if i want to hide the step for only one scope it doesn't work. For example the following configuration should say the step is visible during submission scope but hidden during the workflow scope

<step-definition id="traditionalpageone" mandatory="true">
    <heading>submit.progressbar.describe.stepone</heading>
    <processing-class>org.dspace.app.rest.submit.step.DescribeStep</processing-class>
    <type>submission-form</type>
    <scope visibilityOutside="hidden">submission</scope>
</step-definition>

To Reproduce
Steps to reproduce the behavior:

  1. Change the submission configuration in order to set the visibility of a step like the following
<step-definition id="traditionalpageone" mandatory="true">
    <heading>submit.progressbar.describe.stepone</heading>
    <processing-class>org.dspace.app.rest.submit.step.DescribeStep</processing-class>
    <type>submission-form</type>
    <scope visibilityOutside="hidden">submission</scope>
</step-definition>
  1. Create a new submission in a collection where workflow is enabled and that it's using the submission configuration set in the previous step
  2. The step is visible during submission
  3. deposit the item
  4. as admin claim the workflow item created and edit it
  5. the same step which should be hidden is visible anyway

Expected behavior
It should be possible hide a submission step just for one specified scope

Related work
Link to any related tickets or PRs here.

@atarix83 atarix83 added the bug label Aug 29, 2024
@atarix83 atarix83 self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant