Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no csl on jdk17 builds #352

Open
floriangantner opened this issue Jul 5, 2023 · 2 comments · May be fixed by #354
Open

no csl on jdk17 builds #352

floriangantner opened this issue Jul 5, 2023 · 2 comments · May be fixed by #354
Labels

Comments

@floriangantner
Copy link

floriangantner commented Jul 5, 2023

Describe the bug
On jdk17 build no csl can be generated because the used citeproc dependecy is old.

jdk11 builds mention some warning on startup like: NashornEngine is deprecated

To Reproduce
Steps to reproduce the behavior:

  1. build dspace server webapp with jdk17
  2. start dspace server webapp
  3. trigger some export of some publication as csl, e.g. in chicago style
  4. no csl is generated and some error is logged

Expected behavior
We expect the csl to be generated.

Related work
https://github.com/4Science/DSpace/blob/e69f96c19984b87dc80e0803044bae289a8bf11f/dspace-api/pom.xml#L851C16-L851C16
There are some newer versions of citeproc which are compatible with jdk17. See PR.
As some general workaround the nashorn-core dependency can be added to jdk17 builds so citeproc 1.0.1 is stll working.

@floriangantner floriangantner linked a pull request Jul 6, 2023 that will close this issue
8 tasks
@corrad82-4s
Copy link

hello @floriangantner , as anticipated during our DSpace-CRIS 7 working group call, this is the commit who introduced the possibility of using an external service as CSL generator: 73fe8c9 . To use an external service, we deployed this project https://github.com/zotero/citeproc-js-server on a web server, then set property csl.web-service.url with the url of the service.

@floriangantner
Copy link
Author

superseeded by PR #483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants