๐ [Fix] pchange ํ์คํ ๋ฆฌ ์กฐํ ์ game ์๊ฐ ๊ธฐ์ค์ด ์๋ ๊ฒ์ ์ ์ ์ ๋ ฅ ์๊ฐ ์กฐํ ์์ #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests โ
Additional details and impacted files@@ Coverage Diff @@
## dev #731 +/- ##
============================================
- Coverage 74.16% 72.80% -1.37%
- Complexity 737 1007 +270
============================================
Files 166 344 +178
Lines 3178 4614 +1436
Branches 340 394 +54
============================================
+ Hits 2357 3359 +1002
- Misses 677 1077 +400
- Partials 144 178 +34
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. |
AYoungSn
reviewed
Mar 13, 2024
| @@ -14,6 +14,6 @@ public class UserHistoryData { | |||
|
|
|||
| public UserHistoryData(PChange pChange) { | |||
| this.ppp = pChange.getPppResult(); | |||
| this.date = pChange.getCreatedAt(); | |||
| this.date = pChange.getGame().getStartTime(); | |||
There was a problem hiding this comment.
pchange ๊ฐ์ ธ์ค๋ ์ฟผ๋ฆฌ๊ฐ fetch join ์ผ๋ก ์๋์ด์๋๋ฐ, ์ถ๊ฐ ์ฟผ๋ฆฌ ๋ฐ์์ํ๋์?
There was a problem hiding this comment.
ํ์ธ ๊ฒฐ๊ณผ ์ถ๊ฐ ์ฟผ๋ฆฌ๊ฐ ๋ง์ด ๋ฐ์ํ์ฌ ํด๋น ์ฟผ๋ฆฌ๋ฌธ์์ Game์ fetch join์ผ๋ก ์์ ํ ๊นํ๋๋ฐ ๊ด์ฐฎ์๊น์?
There was a problem hiding this comment.
๋ต ํ๋๊ฒ ์ข์๊ฒ ๊ฐ์ต๋๋ค!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ ๊ฐ์
๐ป ์์ ์ฌํญ
๐กIssue ๋ฒํธ