Some suggestions for access token expiration selector #3951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #3943 I saw some things that I thought could be improved, but I was not sure exactly what would be a better way, so I played around a bit.
Probably not everything should be applied, but can be considered as food for thought.
Mainly the changes are:
span
element to the right (which dos not look very Patternfly-y). The drawback is that when the select is expanded, the value is not seen, but I think it doesn't matter.In addition to the last item, it would probably be nice to add an error message when the expiration is set to some time in the past. With this validator it is probably not that relevant, but if the past dates were esasily pickable, an error message saying that past dates can't be selected would be nice (but not required).